Fix for zombie invalid and penalized txs (hyperledger#7659)

Signed-off-by: Fabio Di Fabio <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]>
Consensys · Sep 30, 2024 · ffef4d5 · ffef4d5
1 parent 23ad2b5
commit ffef4d5
Showing 1 changed file with 1 addition and 3 deletions.
diff --git a/...va/org/hyperledger/besu/ethereum/eth/transactions/layered/LayeredPendingTransactions.java b/...va/org/hyperledger/besu/ethereum/eth/transactions/layered/LayeredPendingTransactions.java
@@ -351,9 +351,7 @@ public void selectTransactions(final PendingTransactions.TransactionSelector sel
                     }
                   });
               logDiscardedTransaction(candidatePendingTx, selectionResult);
-            }
-
-            if (selectionResult.penalize()) {
+            } else if (selectionResult.penalize()) {
               ethScheduler.scheduleTxWorkerTask(
                   () -> {
                     synchronized (this) {