Prover/vertical splitting for limitless prover #547
Conversation
|
|
|
|
| return ContinueCompilation(comp, compilers...) | ||
| } | ||
|
|
||
| // ContinueCompilation continues a set of compilation steps over a initial CompiledIOP object. |
There was a problem hiding this comment.
It's a good idea to add that IMO
…ea-monorepo into prover/vertical-splitting-for-limitless-prover
AlexandreBelling
had a problem deploying
to
docker-build-and-e2e
GitHub Actions
Error
| if run.ParentRuntime == nil { | ||
| utils.Panic("invalid call: the runtime does not have a [ParentRuntime]") | ||
| } | ||
| if run.ProverID > p.numSegments { |
There was a problem hiding this comment.
You should make ProverID a field of segmentModuleProver and not ProverRuntime
There was a problem hiding this comment.
ModulCop for all segments should remain the same and proverID should only affect the prover.
On the other hand the run time already has the parent run time and is natural to say what is the position of the prover among its siblings.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## prover/limitless-top-level #547 +/- ##
=============================================================
Coverage 68.49% 68.49%
Complexity 1130 1130
=============================================================
Files 321 321
Lines 12842 12842
Branches 1287 1287
=============================================================
Hits 8796 8796
Misses 3506 3506
Partials 540 540
*This pull request uses carry forward flags. Click here to find out more. |
Soleimani193
had a problem deploying
to
docker-build-and-e2e
GitHub Actions
Error
Soleimani193
requested a deployment
to
docker-build-and-e2e
GitHub Actions
Waiting
Soleimani193
merged commit 1ebac35
into
prover/limitless-top-level
Soleimani193
deleted the
prover/vertical-splitting-for-limitless-prover
branch
This PR implements the vertical splitting of CompiledIOP and its corresponding prover.
Checklist