Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: breakdown into smaller files and more efficient resources #626

Merged
merged 15 commits into from
Jan 30, 2025

Conversation

jpnovais
Copy link
Collaborator

This PR implements issue(s) #

Checklist

  • I wrote new tests for my new core changes.
  • I have successfully ran tests, style checker and build against my new changes locally.
  • I have informed the team of any breaking changes if there are any.

@jpnovais jpnovais temporarily deployed to docker-build-and-e2e January 29, 2025 18:44 — with GitHub Actions Inactive
@codecov-commenter
Copy link

codecov-commenter commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.46%. Comparing base (a8cdd28) to head (de8c244).

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #626      +/-   ##
============================================
+ Coverage     68.42%   68.46%   +0.03%     
+ Complexity     1182     1181       -1     
============================================
  Files           323      323              
  Lines         13125    13125              
  Branches       1316     1316              
============================================
+ Hits           8981     8986       +5     
+ Misses         3591     3588       -3     
+ Partials        553      551       -2     
Flag Coverage Δ *Carryforward flag
hardhat 98.94% <ø> (ø) Carriedforward from 183b612
kotlin 66.08% <ø> (+0.04%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

see 3 files with indirect coverage changes

@jpnovais jpnovais temporarily deployed to docker-build-and-e2e January 29, 2025 20:09 — with GitHub Actions Inactive
@jpnovais jpnovais force-pushed the local-stack-improv-3 branch from b87c65b to 04489d3 Compare January 29, 2025 21:27
@jpnovais jpnovais force-pushed the local-stack-improv-3 branch from 5483c66 to c4c9ef2 Compare January 30, 2025 09:44
@jpnovais jpnovais requested review from a team January 30, 2025 09:44
@jpnovais jpnovais temporarily deployed to docker-build-and-e2e January 30, 2025 09:45 — with GitHub Actions Inactive
@jpnovais jpnovais temporarily deployed to docker-build-and-e2e January 30, 2025 10:31 — with GitHub Actions Inactive
@jpnovais jpnovais temporarily deployed to docker-build-and-e2e January 30, 2025 10:48 — with GitHub Actions Inactive
Filter94
Filter94 previously approved these changes Jan 30, 2025
Filter94
Filter94 previously approved these changes Jan 30, 2025
@jpnovais jpnovais force-pushed the local-stack-improv-3 branch from 55732a3 to 183b612 Compare January 30, 2025 12:58
@jpnovais jpnovais temporarily deployed to docker-build-and-e2e January 30, 2025 12:59 — with GitHub Actions Inactive
@jpnovais jpnovais temporarily deployed to docker-build-and-e2e January 30, 2025 14:10 — with GitHub Actions Inactive
@jpnovais jpnovais requested a review from Filter94 January 30, 2025 15:06
@jpnovais jpnovais merged commit a63965e into main Jan 30, 2025
23 checks passed
@jpnovais jpnovais deleted the local-stack-improv-3 branch January 30, 2025 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants