Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] Floating pragma for inherited contracts #630

Merged
merged 3 commits into from
Feb 4, 2025

Conversation

kyzooghost
Copy link
Contributor

This PR implements issue(s) #616

Checklist

  • I wrote new tests for my new core changes.
  • I have successfully ran tests, style checker and build against my new changes locally.
  • I have informed the team of any breaking changes if there are any.

Sorry, something went wrong.

@kyzooghost kyzooghost requested a review from a team as a code owner January 30, 2025 10:20
@kyzooghost kyzooghost changed the title floating pragma for inherited contracts [Feat] Floating pragma for inherited contracts Jan 30, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.42%. Comparing base (253a51a) to head (d9eec79).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #630      +/-   ##
============================================
+ Coverage     68.39%   68.42%   +0.03%     
- Complexity     1181     1182       +1     
============================================
  Files           323      323              
  Lines         13125    13125              
  Branches       1316     1316              
============================================
+ Hits           8977     8981       +4     
+ Misses         3595     3591       -4     
  Partials        553      553              
Flag Coverage Δ *Carryforward flag
hardhat 98.94% <ø> (ø)
kotlin 66.04% <ø> (+0.03%) ⬆️ Carriedforward from ccc1f92

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
...ntracts/src/libraries/EfficientLeftRightKeccak.sol 100.00% <ø> (ø)
...ontracts/src/libraries/TransientStorageHelpers.sol 100.00% <ø> (ø)
contracts/src/messaging/MessageServiceBase.sol 100.00% <ø> (ø)
contracts/src/messaging/l1/L1MessageManager.sol 100.00% <ø> (ø)
contracts/src/messaging/l1/L1MessageService.sol 100.00% <ø> (ø)
...ntracts/src/messaging/l1/v1/L1MessageManagerV1.sol 100.00% <ø> (ø)
...ntracts/src/messaging/l1/v1/L1MessageServiceV1.sol 100.00% <ø> (ø)
contracts/src/messaging/l2/L2MessageManager.sol 100.00% <ø> (ø)
...ntracts/src/messaging/l2/v1/L2MessageManagerV1.sol 100.00% <ø> (ø)
...ntracts/src/messaging/l2/v1/L2MessageServiceV1.sol 100.00% <ø> (ø)
... and 7 more

... and 2 files with indirect coverage changes

@kyzooghost kyzooghost temporarily deployed to docker-build-and-e2e January 30, 2025 10:36 — with GitHub Actions Inactive
@kyzooghost kyzooghost temporarily deployed to docker-build-and-e2e February 4, 2025 07:17 — with GitHub Actions Inactive
@kyzooghost kyzooghost merged commit 1a811f4 into main Feb 4, 2025
24 checks passed
@kyzooghost kyzooghost deleted the feat/interface-floating-pragma branch February 4, 2025 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants