Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: migrate metamask flask handle to metamask #121

Merged
merged 3 commits into from
Sep 1, 2023
Merged

feat: migrate metamask flask handle to metamask #121

merged 3 commits into from
Sep 1, 2023

Conversation

stanleyyconsensys
Copy link
Collaborator

@stanleyyconsensys stanleyyconsensys commented Aug 23, 2023 •
edited
Loading

  • add metamask detect and alert model
  • update flask content to metamask content
  • update fox icon
  • add starknet icon to snap
  • fix lint style
  • handle multi wallets

ticket: https://consensyssoftware.atlassian.net/jira/software/projects/SF/boards/472?selectedIssue=SF-517

@stanleyyconsensys
feat: migrate metamask flask handle to metamask
12cee4d 
- add metamask detect and alert model
- update flask content to metamask content
- update fox icon
- add starknet icon to snap
- fix lint style
@stanleyyconsensys stanleyyconsensys requested a review from a team as a code owner August 23, 2023 11:44
wantedsystem
wantedsystem previously approved these changes Aug 24, 2023
View reviewed changes
Copy link
Contributor

@wantedsystem wantedsystem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/wallet-ui/src/components/ui/organism/NoFlaskModal/NoFlaskModal.style.ts
@@ -1,6 +1,6 @@
import styled from 'styled-components';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still want to use snaps with Flask ? if it's not the case you can add a comment to remember that we need to remove this component after releasing the snaps in production

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noted, will add a comment to remove this component after release

@sonarcloud
Copy link

sonarcloud bot commented Aug 28, 2023

[consensys_starknet-snap-starknet-snap] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@sonarcloud
Copy link

sonarcloud bot commented Aug 28, 2023

[consensys_starknet-snap-wallet-ui] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

0.0% 0.0% Coverage
21.9% 21.9% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@stanleyyconsensys stanleyyconsensys merged commit 5eff492 into main Sep 1, 2023
5 checks passed
@stanleyyconsensys stanleyyconsensys deleted the feat/SF-517-wallet-ui-migrate-to-metamask-from-metamask-flask branch September 1, 2023 09:18
@github-actions github-actions bot mentioned this pull request Sep 1, 2023
Merged
@github-actions github-actions bot mentioned this pull request Sep 12, 2023
Merged
This was referenced Nov 26, 2024
Closed
Closed
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wantedsystem wantedsystem wantedsystem left review comments

@Julink-eth Julink-eth Awaiting requested review from Julink-eth Julink-eth is a code owner automatically assigned from Consensys/snaps-factory-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stanleyyconsensys @wantedsystem