Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sf-640 revamp cicd workflow #255

Merged
merged 18 commits into from
Jun 20, 2024
Merged

Conversation

stanleyyconsensys
Copy link
Collaborator

@stanleyyconsensys stanleyyconsensys commented Jun 18, 2024

This PR is to clean up the CICD and try to standardise with metamask workflow if possible

  • add get starknet deployment flow
  • remove story book workflow, as we dont have any use case for now
  • combine deploy-dev, publish-npm-dev into deploy.yml, to let github taking care the dynamic variable "AWS_S3_URL" and "AWS_CLOUDFRONT_DISTRIBUTIONS_ID", and simplify the workflow
  • standardise package.json cmd, to have start, build, test, lint, lint, clean, serve on every workspace
  • remove yarn setup, as it is duplicate with yarn install, instead replace by allow-scripts from root
  • remove e2e, as it is not enable for now

New workflow:
Main (trigger by any push or pull request to main, to test workflow and the code)
image

Deploy (trigger by manual, allow deploy to dev,staging,prod)
image

Existing workflow:
lint-pr-title, terraform, release-please will remain the same

Removed workflow:
e2e-tests -> removed with no use case
e2e-tests-slack-notification -> removed with no use case
storybook -> removed with no use case
deploy-dev -> merged to deploy
publish-npm-dev -> merged to deploy
build-test -> merged to main

Note:
In MM workflow, they dont have dev , staging deployment, but mostly 1 go to PROD by manual create a release PR request, and merge the PR, and then the pipeline will deploy to prod
in Starknet workflow, we do it by auto create release PR when ever a push to main, and manual deploy to different env for more flexible choice, e.g we can deploy a version b4 release PR or after release PR

Ticket:
https://consensyssoftware.atlassian.net/jira/software/projects/SF/boards/472?selectedIssue=SF-640

@stanleyyconsensys stanleyyconsensys requested a review from a team as a code owner June 18, 2024 04:12
@stanleyyconsensys stanleyyconsensys changed the title feat: add new cd workflow feat: revamp cicd workflow Jun 18, 2024
Copy link
Collaborator

@khanti42 khanti42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just small comment regarding ubuntu image version and the storybook entry. Otherwise do you think it makes sense to add the automatic deployment of remoteEntry.js to s3 into the cicd workflow already with this merge ?

.github/workflows/deploy.yml Show resolved Hide resolved
packages/wallet-ui/package.json Show resolved Hide resolved
khanti42
khanti42 previously approved these changes Jun 19, 2024
Copy link
Collaborator

@khanti42 khanti42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

Please retry analysis of this Pull-Request directly on SonarCloud

@stanleyyconsensys stanleyyconsensys changed the title feat: revamp cicd workflow feat: sf-640 revamp cicd workflow Jun 20, 2024
Copy link

Quality Gate Passed Quality Gate passed for 'consensys_starknet-snap-starknet-snap'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

Quality Gate Passed Quality Gate passed for 'consensys_starknet-snap-wallet-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@stanleyyconsensys stanleyyconsensys merged commit 6faaf02 into main Jun 20, 2024
13 checks passed
@stanleyyconsensys stanleyyconsensys deleted the feat/revamp-cicd-pipeline branch June 20, 2024 05:29
@github-actions github-actions bot mentioned this pull request Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants