-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: sf-640 revamp cicd workflow #255
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just small comment regarding ubuntu image version and the storybook entry. Otherwise do you think it makes sense to add the automatic deployment of remoteEntry.js to s3 into the cicd workflow already with this merge ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Please retry analysis of this Pull-Request directly on SonarCloud |
Quality Gate passed for 'consensys_starknet-snap-starknet-snap'Issues Measures |
Quality Gate passed for 'consensys_starknet-snap-wallet-ui'Issues Measures |
This PR is to clean up the CICD and try to standardise with metamask workflow if possible
New workflow:
Main (trigger by any push or pull request to main, to test workflow and the code)
Deploy (trigger by manual, allow deploy to dev,staging,prod)
Existing workflow:
lint-pr-title, terraform, release-please will remain the same
Removed workflow:
e2e-tests -> removed with no use case
e2e-tests-slack-notification -> removed with no use case
storybook -> removed with no use case
deploy-dev -> merged to deploy
publish-npm-dev -> merged to deploy
build-test -> merged to main
Note:
In MM workflow, they dont have dev , staging deployment, but mostly 1 go to PROD by manual create a release PR request, and merge the PR, and then the pipeline will deploy to prod
in Starknet workflow, we do it by auto create release PR when ever a push to main, and manual deploy to different env for more flexible choice, e.g we can deploy a version b4 release PR or after release PR
Ticket:
https://consensyssoftware.atlassian.net/jira/software/projects/SF/boards/472?selectedIssue=SF-640