feat: sf 644 update eslint #265
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stanleyyconsensys
requested review from
Julink-eth and
jonesho
and removed request for
a team
stanleyyconsensys
changed the base branch from
feat/sf-642-update-dependency
to
main
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pr is to update the eslint config to sync with Metamask Project
In order to update the change, the yarn.lock has to removed and re-created in this PR, due to conflict happen in react-app and eslint from metamask-eslint dependency
the new eslint has apply to wallet-ui, get-starknet, starknet-sanp
the new eslint check will not apply to test file
this PR is depend #259