Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update wallet-ui unsupported MM version management #424

Merged
merged 16 commits into from
Nov 26, 2024

Conversation

khanti42
Copy link
Collaborator

@khanti42 khanti42 commented Nov 18, 2024

Description

This PR is to

  • update the unsupported version message of the wallet-ui to also include MetaMask version update requirements.
  • force MetaMask upgrade to supported version
Screenshot 2024-11-21 at 10 01 40

BEGIN_COMMIT_OVERRIDE
feat: Add minimum MetaMask version requirements detection. (#424)
END_COMMIT_OVERRIDE

@khanti42 khanti42 requested a review from a team as a code owner November 18, 2024 09:36
@khanti42 khanti42 requested review from Julink-eth and wantedsystem and removed request for a team November 18, 2024 09:36
@khanti42 khanti42 changed the title feat: update wallet-ui message feat: update wallet-ui unsupported version message Nov 18, 2024
Copy link
Collaborator

@stanleyyconsensys stanleyyconsensys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@khanti42 khanti42 changed the title feat: update wallet-ui unsupported version message feat: update wallet-ui unsupported MM version management Nov 20, 2024
@khanti42 khanti42 force-pushed the feat/wallet-ui-update-unsupported-version-message branch from e33fb8e to 6dd9931 Compare November 21, 2024 09:40
@khanti42 khanti42 added this pull request to the merge queue Nov 26, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 26, 2024
Copy link

sonarcloud bot commented Nov 26, 2024

Quality Gate Passed Quality Gate passed for 'consensys_starknet-snap-starknet-snap'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Copy link

sonarcloud bot commented Nov 26, 2024

Quality Gate Passed Quality Gate passed for 'consensys_starknet-snap-wallet-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
7.5% Duplication on New Code

See analysis details on SonarQube Cloud

@khanti42 khanti42 added this pull request to the merge queue Nov 26, 2024
Merged via the queue into main with commit f6cde30 Nov 26, 2024
13 checks passed
@khanti42 khanti42 deleted the feat/wallet-ui-update-unsupported-version-message branch November 26, 2024 10:46
@github-actions github-actions bot mentioned this pull request Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants