-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update wallet-ui unsupported MM version management #424
Merged
khanti42
merged 16 commits into
main
from
feat/wallet-ui-update-unsupported-version-message
Nov 26, 2024
Merged
feat: update wallet-ui unsupported MM version management #424
khanti42
merged 16 commits into
main
from
feat/wallet-ui-update-unsupported-version-message
Nov 26, 2024
+77
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khanti42
requested review from
Julink-eth and
wantedsystem
and removed request for
a team
November 18, 2024 09:36
khanti42
changed the title
feat: update wallet-ui message
feat: update wallet-ui unsupported version message
Nov 18, 2024
stanleyyconsensys
previously approved these changes
Nov 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
khanti42
changed the title
feat: update wallet-ui unsupported version message
feat: update wallet-ui unsupported MM version management
Nov 20, 2024
Co-authored-by: Stanley Yuen <[email protected]>
Co-authored-by: Stanley Yuen <[email protected]>
khanti42
force-pushed
the
feat/wallet-ui-update-unsupported-version-message
branch
from
November 21, 2024 09:40
e33fb8e
to
6dd9931
Compare
stanleyyconsensys
previously approved these changes
Nov 26, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Nov 26, 2024
khanti42
commented
Nov 26, 2024
packages/wallet-ui/src/components/ui/organism/MinVersionModal/MinVersionModal.view.tsx
Show resolved
Hide resolved
…MinVersionModal.view.tsx
khanti42
commented
Nov 26, 2024
packages/wallet-ui/src/components/ui/organism/MinVersionModal/MinVersionModal.view.tsx
Outdated
Show resolved
Hide resolved
Quality Gate passed for 'consensys_starknet-snap-starknet-snap'Issues Measures |
Quality Gate passed for 'consensys_starknet-snap-wallet-ui'Issues Measures |
stanleyyconsensys
approved these changes
Nov 26, 2024
khanti42
deleted the
feat/wallet-ui-update-unsupported-version-message
branch
November 26, 2024 10:46
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is to
BEGIN_COMMIT_OVERRIDE
feat: Add minimum MetaMask version requirements detection. (#424)
END_COMMIT_OVERRIDE