chore: add base controller ChainRpcController
#443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stanleyyconsensys
requested review from
Akaryatrh and
jonesho
and removed request for
a team
|
|
1 task
stanleyyconsensys
changed the title
ChainRpcControllerChainRpcController
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to add
ChainRpcControllerfor the case that a RPC doesnt need account discover, but just getting the network instance by a chainIdthe
ChainRpcControllerwill place into './rpcs/abstract'due to stateManager is included
ChainRpcController, it will result a cycle require when some RPC extends the ChainRpcControllerand the other abstract RPC controllers should move to the same place