Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add permission boundary #448

Merged
merged 2 commits into from
Dec 3, 2024
Merged

Conversation

stanleyyconsensys
Copy link
Collaborator

@stanleyyconsensys stanleyyconsensys commented Dec 3, 2024

This PR is to add permission boundary to limit the access of some RPC API by different origins (reference)

It also include:

  • due to no use case exist, we removed the access for RPCs - starkNet_addNetwork, starkNet_estimateAccountDeployFee and starkNet_getStoredTransactions

BEGIN_COMMIT_OVERRIDE
feat: Add permission boundary. Block RPCs - starkNet_addNetwork, starkNet_estimateAccountDeployFee and starkNet_getStoredTransactions access for any origin (#448)
END_COMMIT_OVERRIDE

@stanleyyconsensys stanleyyconsensys requested a review from a team as a code owner December 3, 2024 03:49
@stanleyyconsensys stanleyyconsensys requested review from Julink-eth and jonesho and removed request for a team December 3, 2024 03:49
Copy link

sonarcloud bot commented Dec 3, 2024

Quality Gate Passed Quality Gate passed for 'consensys_starknet-snap-wallet-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Copy link

sonarcloud bot commented Dec 3, 2024

Quality Gate Passed Quality Gate passed for 'consensys_starknet-snap-starknet-snap'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Copy link
Collaborator

@khanti42 khanti42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stanleyyconsensys stanleyyconsensys added this pull request to the merge queue Dec 3, 2024
Merged via the queue into main with commit 1e80070 Dec 3, 2024
16 checks passed
@stanleyyconsensys stanleyyconsensys deleted the feat/add-permission-boundary branch December 3, 2024 12:29
@github-actions github-actions bot mentioned this pull request Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants