Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: handle multi calls on RPC starkNet_executeTxn #457

Merged
merged 45 commits into from
Dec 11, 2024
Merged

chore: handle multi calls on RPC starkNet_executeTxn #457

merged 45 commits into from
Dec 11, 2024

Conversation

stanleyyconsensys
Copy link
Collaborator

@stanleyyconsensys stanleyyconsensys commented Dec 10, 2024 •
edited
Loading

This PR is to add multi-calls support on RPC starkNet_executeTxn
It includes:

  • refactor RPC starkNet_executeTxn with v2 transaction state data and multi-calls
  • add transaction utils for transaction related helper function
  • moving some logic from starkscan to transaction utils , as it can be share

Requirements:

Below PR has to merged before hand:

@stanleyyconsensys
feat: add stark scan client
77f4b7b
@stanleyyconsensys
chore: add starkscan config
6b7a5e2
@stanleyyconsensys
chore: lint
3c9a523
@stanleyyconsensys
chore: add interface
576f302
@stanleyyconsensys
Merge branch 'main' into feat/add-stark-scan-client
19fdf56
@stanleyyconsensys
chore: support multiple txn
5d446cb
@stanleyyconsensys
chore: update starkscan
3dbdf32
@stanleyyconsensys
chore: update stark scan client
924ea45
@stanleyyconsensys
chore: update contract func name
bcf34c7
@stanleyyconsensys
chore: fix test
d1ad70c
@stanleyyconsensys
chore: update data client
1a061d3
@stanleyyconsensys
Merge branch 'main' into feat/add-stark-scan-client
3bda85f
@stanleyyconsensys
Merge branch 'main' into feat/add-stark-scan-client
114ea6d
@stanleyyconsensys
Merge branch 'main' into feat/add-stark-scan-client
7539056
@stanleyyconsensys
chore: re-structure starkscan type
ed699ff
@stanleyyconsensys
chore: add test coverage
93adb36
@stanleyyconsensys
chore: factory and config
dadb493
@stanleyyconsensys
chore: add backward compatibility for transactions type
b21a5d2
@stanleyyconsensys
chore: add comment
07f0232
@stanleyyconsensys
chore: lint
7a26c70
@stanleyyconsensys
chore: resolve review comment
804a2bd
@stanleyyconsensys
chore: change dataVersion to enum
8e9e163
@stanleyyconsensys
chore: lint
b09361f
@stanleyyconsensys
chore: update test helper and refactor ContractAddressFilter
7cbd66f
@stanleyyconsensys
chore: lint
f657422
@stanleyyconsensys
chore: add test for dataVersion filter
4ee01bc
@stanleyyconsensys
chore: update txn state mgr test
3a99e76
@stanleyyconsensys
chore: update search condition
38e5d63
@stanleyyconsensys
chore: update starkscan to handle missing selector_name
63e3030
@stanleyyconsensys
Merge branch 'feat/add-stark-scan-client' into chore/refactor-txn-mgr
6391e81
@stanleyyconsensys stanleyyconsensys requested a review from a team as a code owner December 10, 2024 06:23
@stanleyyconsensys stanleyyconsensys requested review from Akaryatrh and wantedsystem and removed request for a team December 10, 2024 06:23
@stanleyyconsensys stanleyyconsensys changed the title chore: refactor RPC starkNet_executeTxn with v2 transaction state data chore: add v2 transaction state data handle on RPC starkNet_executeTxn, starkNet_createAccount , starkNet_createAccountLegacy, starkNet_upgradeAccContract Dec 10, 2024
@stanleyyconsensys stanleyyconsensys changed the title chore: add v2 transaction state data handle on RPC starkNet_executeTxn, starkNet_createAccount , starkNet_createAccountLegacy, starkNet_upgradeAccContract chore: handle multi calls on RPC starkNet_executeTxn Dec 10, 2024
@stanleyyconsensys stanleyyconsensys mentioned this pull request Dec 10, 2024
Merged
1 task
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 10, 2024

Quality Gate Passed Quality Gate passed for 'consensys_starknet-snap-wallet-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 10, 2024

Quality Gate Passed Quality Gate passed for 'consensys_starknet-snap-starknet-snap'

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
1.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

khanti42
khanti42 approved these changes Dec 10, 2024
View reviewed changes
Copy link
Collaborator

@khanti42 khanti42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stanleyyconsensys stanleyyconsensys merged commit c363481 into feat/refactor-list-transactions-with-starkscan Dec 11, 2024
14 checks passed
@stanleyyconsensys stanleyyconsensys deleted the chore/update-execute-txn-with-new-txn-data branch December 11, 2024 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khanti42 khanti42 khanti42 approved these changes

@Akaryatrh Akaryatrh Awaiting requested review from Akaryatrh Akaryatrh is a code owner automatically assigned from Consensys/snaps-factory-reviewers

@wantedsystem wantedsystem Awaiting requested review from wantedsystem wantedsystem is a code owner automatically assigned from Consensys/snaps-factory-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stanleyyconsensys @khanti42