Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update wallet-ui to match new getTransactions rpc format #459

Merged
merged 43 commits into from
Dec 11, 2024

Conversation

khanti42
Copy link
Collaborator

No description provided.

@khanti42 khanti42 requested a review from a team as a code owner December 11, 2024 08:27
@khanti42 khanti42 requested review from Akaryatrh and stanleyyconsensys and removed request for a team December 11, 2024 08:27
Copy link
Collaborator

@stanleyyconsensys stanleyyconsensys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, i can give approve first, but you can choose to fix those comment

packages/wallet-ui/src/types/index.ts Outdated Show resolved Hide resolved
packages/wallet-ui/src/types/index.ts Outdated Show resolved Hide resolved
@khanti42 khanti42 merged commit 789b8bd into feat/refactor-list-transactions-with-starkscan Dec 11, 2024
3 checks passed
@khanti42 khanti42 deleted the chore/sf-742 branch December 11, 2024 10:55
Copy link

sonarcloud bot commented Dec 11, 2024

Quality Gate Passed Quality Gate passed for 'consensys_starknet-snap-starknet-snap'

Issues
5 New issues
0 Accepted issues

Measures
0 Security Hotspots
9.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Copy link

sonarcloud bot commented Dec 11, 2024

Quality Gate Passed Quality Gate passed for 'consensys_starknet-snap-wallet-ui'

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants