feat: add new RPC starkNet_addAccount
#474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stanleyyconsensys
requested review from
Akaryatrh and
jonesho
and removed request for
a team
This was referenced Jan 13, 2025
Merged
khanti42
changed the base branch from
feat/enable-multiple-accounts
to
refactor/adopt-account-discovery
khanti42
requested changes
Jan 13, 2025
khanti42
approved these changes
Jan 14, 2025
Base automatically changed from
refactor/adopt-account-discovery
to
feat/enable-multiple-accounts
January 14, 2025 11:57
khanti42
approved these changes
Jan 14, 2025
|
|
stanleyyconsensys
merged commit 61ea119
into
feat/enable-multiple-accounts
14 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to add new RPC
starkNet_addAccountChanges:
Add new RPC
starkNet_addAccountA
MaxAccountLimitExceededErrorwill be thrown if more than 2 account created in the same networkAdd permission and entry point for RPC
starkNet_addAccountAdd the missing test for
AccountStateManagerRemove
addAccountandupdateAccountfromAccountStateManager, as no use case exist.Requirements: