-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add new RPC starkNet_switchAccount
#478
Merged
stanleyyconsensys
merged 31 commits into
feat/enable-multiple-accounts
from
feat/switch-account-rpc
Jan 15, 2025
Merged
feat: add new RPC starkNet_switchAccount
#478
stanleyyconsensys
merged 31 commits into
feat/enable-multiple-accounts
from
feat/switch-account-rpc
Jan 15, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stanleyyconsensys
requested review from
Julink-eth and
jonesho
and removed request for
a team
January 13, 2025 09:31
stanleyyconsensys
changed the title
feat: add new RPC
feat: add new RPC Jan 13, 2025
starkNet_swtichAccount
starkNet_swtichAccount
khanti42
changed the base branch from
feat/enable-multiple-accounts
to
feat/list-accounts-rpc
January 13, 2025 12:32
khanti42
approved these changes
Jan 13, 2025
1 task
khanti42
changed the title
feat: add new RPC
feat: add new RPC Jan 14, 2025
starkNet_swtichAccount
starkNet_switchAccount
Base automatically changed from
feat/list-accounts-rpc
to
feat/enable-multiple-accounts
January 15, 2025 07:49
Quality Gate passed for 'consensys_starknet-snap-wallet-ui'Issues Measures |
Quality Gate passed for 'consensys_starknet-snap-starknet-snap'Issues Measures |
stanleyyconsensys
merged commit Jan 15, 2025
1ec0dcd
into
feat/enable-multiple-accounts
14 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to add new RPC
starkNet_swtichAccount
, it will set the current account of the given network to the given account.Changes:
starkNet_swtichAccount
starkNet_swtichAccount
Requirements:
starkNet_listAccounts
#477