Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new RPC starkNet_switchAccount #478

Merged

Conversation

stanleyyconsensys
Copy link
Collaborator

This PR is to add new RPC starkNet_swtichAccount, it will set the current account of the given network to the given account.

Changes:

  • Add new RPC starkNet_swtichAccount
  • Add permission and entry point for RPC starkNet_swtichAccount
  • switching an account will also update the metadata of the account

Requirements:

@stanleyyconsensys stanleyyconsensys requested a review from a team as a code owner January 13, 2025 09:31
@stanleyyconsensys stanleyyconsensys requested review from Julink-eth and jonesho and removed request for a team January 13, 2025 09:31
@stanleyyconsensys stanleyyconsensys changed the title feat: add new RPC starkNet_swtichAccount feat: add new RPC starkNet_swtichAccount Jan 13, 2025
@khanti42 khanti42 changed the base branch from feat/enable-multiple-accounts to feat/list-accounts-rpc January 13, 2025 12:32
@khanti42 khanti42 changed the title feat: add new RPC starkNet_swtichAccount feat: add new RPC starkNet_switchAccount Jan 14, 2025
Base automatically changed from feat/list-accounts-rpc to feat/enable-multiple-accounts January 15, 2025 07:49
Copy link

Quality Gate Passed Quality Gate passed for 'consensys_starknet-snap-wallet-ui'

Issues
6 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Copy link

Quality Gate Passed Quality Gate passed for 'consensys_starknet-snap-starknet-snap'

Issues
7 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.8% Coverage on New Code
0.7% Duplication on New Code

See analysis details on SonarQube Cloud

@stanleyyconsensys stanleyyconsensys merged commit 1ec0dcd into feat/enable-multiple-accounts Jan 15, 2025
14 checks passed
@stanleyyconsensys stanleyyconsensys deleted the feat/switch-account-rpc branch January 15, 2025 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants