Deprecate TTFB, RESP_TIMEOUT, introduce MAX_CONCURRENT_REQUESTS #8839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StefanBratanov
force-pushed
the
p2p_deprecation
branch
from
89c03f3
to
0ce2fe1
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...th2/src/main/java/tech/pegasys/teku/networking/eth2/rpc/core/Eth2IncomingRequestHandler.java
Fixed
Show fixed
Hide fixed
tbenr
reviewed
Nov 22, 2024
...th2/src/main/java/tech/pegasys/teku/networking/eth2/rpc/core/Eth2OutgoingRequestHandler.java
Outdated
Show resolved
Hide resolved
networking/p2p/src/main/java/tech/pegasys/teku/networking/p2p/libp2p/rpc/RpcHandler.java
Outdated
Show resolved
Hide resolved
networking/p2p/src/test/java/tech/pegasys/teku/networking/p2p/libp2p/rpc/RpcHandlerTest.java
Fixed
Show fixed
Hide fixed
networking/p2p/src/test/java/tech/pegasys/teku/networking/p2p/libp2p/rpc/RpcHandlerTest.java
Fixed
Show fixed
Hide fixed
StefanBratanov
force-pushed
the
p2p_deprecation
branch
from
9d5ea69
to
acf6314
Compare
StefanBratanov
changed the title
|
Shouldn't we remove the obsolete constants from // in seconds
int getTtfbTimeout();
// in seconds
int getRespTimeout(); |
Nashatyrev
reviewed
Dec 2, 2024
| this.asyncRunner = asyncRunner; | ||
| this.rpcMethod = rpcMethod; | ||
| concurrentRequestsQueue = ThrottlingTaskQueue.create(maxConcurrentRequests); |
There was a problem hiding this comment.
As far as I understand here we are limiting ourselves for max concurrent outgoing requests? Do we have the code which enforces inbound limit?
StefanBratanov
force-pushed
the
p2p_deprecation
branch
from
cb3e4b6
to
17e8938
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Main changes are in
Eth2IncomingRequestHandler,Eth2OutgoingRequestHandlerandRpcHandlerReintroduced the timeouts as constants to handle slow servers. Furthermore, they could be should probably be configured per different methods. (as per the consensus-specs PR describes)
Fixed Issue(s)
related to #8803
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog