Updated to work with latest langchain API #57
Conversation
There was a problem hiding this comment.
this is good overall, but i also get this warning when i submit a query:
I'm using this notebook to test.
i've added a few other minor suggestions too
| @@ -77,7 +76,8 @@ def __init__(self, config): | |||
| self.llm_models_factory = ModelsFactory() | |||
|
|
|||
| self.cache = config["cache_config"]["cache"] | |||
There was a problem hiding this comment.
should we ust change this to self.cache = False for now to be extra safe?
There was a problem hiding this comment.
Yes, that would work!
| @@ -153,7 +153,7 @@ def gpt(self, inputs, prompt): | |||
| output : str | |||
| The GPT model output in markdown format. | |||
| """ | |||
| # TODO: Should we create the chain every time? Only prompt is chainging not the model | |||
| # TODO: Should we create the chain every time? Only prompt is changing not the model | |||
There was a problem hiding this comment.
i've added an issue for this
| --- | ||
| {text} | ||
| --- | ||
|
|
||
| I'd like the correct answer to be either "[A]", "[B]", "[C]", or "[D]". Can you make up a multiple choice question for me so that I can make sure I really understant the most important concepts? Remember that I can't respond to you, so just ask me to "think about" which choice is correct or something else like that (i.e., without explicitly responding to you). Put two line breaks ("<br>") between each choice so that it appears correctly on my screen. In other words, there should be two line breaks between each of [B], [C], and [D]. | ||
| I'd like the correct answer to be either "[A]", "[B]", "[C]", or "[D]". Can you make up a multiple choice question for me so that I can make sure I really understand the most important concepts? Remember that I can't respond to you, so just ask me to "think about" which choice is correct or something else like that (i.e., without explicitly responding to you). Put two line breaks ("<br>") between each choice so that it appears correctly on my screen. In other words, there should be two line breaks between each of [B], [C], and [D]. |
There was a problem hiding this comment.
actually: we'll need to update chatify-server for this change to actually take effect. but still good to make this change.
| @@ -11,15 +11,14 @@ | |||
| history = history_file.read() | |||
|
|
|||
| requirements = [ | |||
| "gptcache<=0.1.35", | |||
| "langchain<=0.0.226", | |||
| "langchain>=0.2.6", | |||
There was a problem hiding this comment.
should this be strictly greater than?
There was a problem hiding this comment.
or...do we even need to pin a version?
There was a problem hiding this comment.
I agree with you, no need to pin the version.
This PR update the langchain requirement to the latest version (>=0.2.6). The only change required is the requirement of langchain-community package.