Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PYT-3680 Remove build for python 3.8 #414

Merged
merged 1 commit into from
Jan 21, 2025
Merged

Conversation

lazorchakp
Copy link
Contributor

Not sure if this is the right order of operations, but the python agent team is dropping support for python version 3.8 in the next release.

Should this PR go through first, and then we release the agent, or the other way around?

Copy link

Images built:

dotnet-core: ghcr.io/contrast-security-oss/agent-operator-images/agent-dotnet-core@sha256:65cfa275e0456fa7ab52fb4d4fdfdd32f87da64750a3db46c8be75961d60085d
dotnet-framework: ghcr.io/contrast-security-oss/agent-operator-images/agent-dotnet-framework@sha256:efaef38e58c356ba896b2715910b57d28589ac7447123d355faa0bbccbf25f4d
java: ghcr.io/contrast-security-oss/agent-operator-images/agent-java@sha256:ab75e28313022f41061350731077c45f2810702aeec40f8b07251466cfe8018b
nodejs: ghcr.io/contrast-security-oss/agent-operator-images/agent-nodejs@sha256:775e70fb012656d680aff007ed69b1d3df2451eb53f4296684893b41d294e8db
php: ghcr.io/contrast-security-oss/agent-operator-images/agent-php@sha256:8c478f862c972b7895fb649c210065759e7a5d7bdb40ef104f7dd176eed4ab9f
python: ghcr.io/contrast-security-oss/agent-operator-images/agent-python@sha256:c6681882e7c9a23495da6174bc1f5f19bbda3112a0ec15703c68c5247a168a92

@lazorchakp lazorchakp marked this pull request as ready for review January 17, 2025 22:28
@lazorchakp lazorchakp requested a review from a team as a code owner January 17, 2025 22:28
@@ -56,17 +56,6 @@ RUN set -xe \
&& pip install --target=/contrast "contrast-agent==${VERSION}" \
&& echo "{ \"version\": \"${VERSION}\" }" > /contrast/image-manifest.json

FROM python:3.8-slim-bookworm AS builder-38

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still hate codenames, even when third parties use them. bullseye is now bookworm, :coolcoolcool: ?

Copy link
Contributor

@contrast-jproberts contrast-jproberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure we want to merge this PR before releasing the next agent. If we release the agent first, then the dispatched workflow should fail to build because it won't be able to pip install contrast-agent==10.0.0.

Technically if another agent is released, a new image will be made without py3.8 support, but I don't think that really matters. If it breaks an environment, that environment would have broken on the Python agent 10.0.0 anyway, which would shortly follow.

The change LGTM as a python-team codeowner, so approving. I'd definitely like to know Morgan's opinion before merging though.

edit: and harold sniped me

@gamingrobot gamingrobot merged commit d68c466 into master Jan 21, 2025
15 checks passed
@gamingrobot gamingrobot deleted the remove-python-38-build branch January 21, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants