Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save & restore: support search on PV name(s) #2905

Merged
merged 7 commits into from
Jan 16, 2024
Merged

Save & restore: support search on PV name(s) #2905

merged 7 commits into from
Jan 16, 2024

Conversation

georgweiss
Copy link
Collaborator

In save&restore search view user may specify comma separated list of PV names to use in query.
Input field supports PV name completion backed by channel finder.
Search result will contain only configuration nodes.
Search will consider both setpoint PV and readback PV.
PV names must match exactly, wildcard not supported.
Documentation updated.

@georgweiss georgweiss requested a review from shroffk January 16, 2024 10:55
@shroffk shroffk merged commit f58535b into master Jan 16, 2024
2 checks passed
@shroffk
Copy link
Member

shroffk commented Jan 16, 2024

So, I will close my implementation... which differed in 2 ways

  1. it was searching both configs and snapshots... but I guess if you locate the configuration locating the snapshot is easy. In someway I guess your implementation is better since you have narrower search results.

  2. I was using match instead of term queries.

{
  "query": {
    "match": {
      "pvList": {
        "query": "BR:[RRR]_string_{00005}"
      }
    }
  }
}

I do not observe any functional difference between the two, so we can stick to the term queries which fit better with the strict PV name mapping.
In the future if we want to support a bit more flexible searching then we might want to consider match ( however the usefulness is limited by the flattened mapping )

@shroffk shroffk deleted the CSSTUDIO-1966 branch April 11, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants