CSSTUDIO-2749 Add configuration option 'org.csstudio.display.builder.representation/svg_rendering_resolution_factor' #3197
Conversation
…representation/svg_rendering_resolution_factor'.
| @@ -53,11 +54,20 @@ public class SVGHelper { | |||
| */ | |||
| public static Image loadSVG(String imageFileName, double width, double height) { | |||
| String cachedSVGFileName = imageFileName + "_" + width + "_" + height; | |||
|
|
|||
| double svg_rendering_resolution_factor; | |||
| if (!Double.isNaN(Preferences.svg_rendering_resolution_factor) && Preferences.svg_rendering_resolution_factor > 0) { | |||
There was a problem hiding this comment.
Would it make sense to enforce a minimum value of 1.0 instead of 0.0?
There was a problem hiding this comment.
Would it make sense to enforce a minimum value of 1.0 instead of 0.0?
It would certainly be possible. I implemented it like this since values greater than 0 (e.g., 0.5) are meaningful: then SVGs will not appear sharp unless one zooms out.
|
Seems the scaling factor applies globally to all SVGs -> increased memory usage even if zooming is not used? |
Yes, this is correct. |
|
ESS makes extensive (extensive!) use of SVGs. I would prefer the scaling factor to be applied only upon zoom actions. |
I will try to implement and evaluate this alternative approach. |
This pull request adds the configuration option
org.csstudio.display.builder.representation/svg_rendering_resolution_factorto Phoebus.Setting this option to a value greater than
0.0scales the resolution that SVGs are rendered at both horizontally and vertically by that factor, at the expense of significant memory consumption: the memory consumption of rendered SVGs scales as the square oforg.csstudio.display.builder.representation/svg_rendering_resolution_factor: whenorg.csstudio.display.builder.representation/svg_rendering_resolution_factor=1.9, then the memory consumption will be (approximately) 3.61 times larger than the memory consumption whenorg.csstudio.display.builder.representation/svg_rendering_resolution_factor=1.0.The motivation for the functionality is to enable sharper rendering of SVGs when zooming in.
By default,
org.csstudio.display.builder.representation/svg_rendering_resolution_factoris set to1.0.