Removed search query paramater for security reasons & to fix a bug

CookieJarApps · Aug 3, 2020 · 38ba7b7 · 38ba7b7
1 parent d57c1dc
commit 38ba7b7
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 3 deletions.
diff --git a/.idea/caches/build_file_checksums.ser b/.idea/caches/build_file_checksums.ser
diff --git a/app/src/main/java/com/cookiegames/smartcookie/search/suggestions/BaseSuggestionsModel.kt b/app/src/main/java/com/cookiegames/smartcookie/search/suggestions/BaseSuggestionsModel.kt
@@ -32,6 +32,9 @@ abstract class BaseSuggestionsModel internal constructor(
 
     private val language = locale.language.takeIf(String::isNotEmpty) ?: DEFAULT_LANGUAGE
 
+
+
+
     /**
      * Create a URL for the given query in the given language.
      *

diff --git a/app/src/main/java/com/cookiegames/smartcookie/search/suggestions/GoogleSuggestionsModel.kt b/app/src/main/java/com/cookiegames/smartcookie/search/suggestions/GoogleSuggestionsModel.kt
@@ -34,13 +34,13 @@ class GoogleSuggestionsModel(
         .host("suggestqueries.google.com")
         .encodedPath("/complete/search")
         .addQueryParameter("output", "toolbar")
-        .addQueryParameter("hl", language)
+        //.addQueryParameter("hl", language)
         .addEncodedQueryParameter("q", query)
         .build()
 
     @Throws(Exception::class)
     override fun parseResults(responseBody: ResponseBody): List<SearchSuggestion> {
-        parser.setInput(responseBody.byteStream(), "ISO-8859-1")
+        parser.setInput(responseBody.byteStream(), encoding)
         val suggestions = mutableListOf<SearchSuggestion>()
         var eventType = parser.eventType
         while (eventType != XmlPullParser.END_DOCUMENT) {
@@ -63,5 +63,7 @@ class GoogleSuggestionsModel(
             }.newPullParser()
         }
 
+        var encoding = "ISO-8859-1"
+
     }
 }
diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml
@@ -237,7 +237,7 @@
     <string name="tabs">Tabs</string>
     <string name="theme">App theme</string>
     <string name="light_theme">Light theme</string>
-    <string name="black_theme">Black theme</string>
+    <string name="black_theme">AMOLED theme</string>
     <string name="blue_theme">Blue theme</string>
     <string name="yellow_theme">Yellow theme</string>
     <string name="green_theme">Green theme</string>
-Original file line number
+Diff line change
@@ Expand Up / @@ -32,6 +32,9 @@ abstract class BaseSuggestionsModel internal constructor( @@
         private val language = locale.language.takeIf(String::isNotEmpty) ?: DEFAULT_LANGUAGE
         /**
          * Create a URL for the given query in the given language.
          *
@@ Expand Down @@