Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "enabled" flag for SQS Offline #117

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add "enabled" flag for SQS Offline #117

wants to merge 1 commit into from

Conversation

fernyettheplant
Copy link

We had some cases that we wanted to do isolated functional tests but SQS was always required by it. With this flag, you can disable SQS offline if you need to run certain modules of your Serverless offline application in isolation.

@godu godu added the enhancement New feature or request label Jun 16, 2020
Copy link
Member

@AdrieanKhisbe AdrieanKhisbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Would be interesting to have it applied to the other offline plugins.

I can take care if you want @jefer590 , along with rebasing to fix conflict, (and maybe little refactor (quick exit if (!enabled) return log();)

@AdrieanKhisbe AdrieanKhisbe self-assigned this Sep 25, 2020
@fernyettheplant
Copy link
Author

@AdrieanKhisbe thanks for the review
sure, go ahead :)

@macrouch
Copy link

What ever happened to this? This feature would be extremely useful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants