Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: input for items with args #79

Merged
merged 1 commit into from
Feb 26, 2024
Merged

Conversation

nisalVD
Copy link
Contributor

@nisalVD nisalVD commented Feb 26, 2024

Hi,
I don't know if this the correct way to use this, but when i tried it made more sense to have a space after these commands for input.

calling CopilotChatBuffer with no args throw

E471: Argument Required

Copy link
Contributor

@jellydn jellydn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nisalVD LGTM!

@jellydn jellydn merged commit 88f7b8b into CopilotC-Nvim:main Feb 26, 2024
1 of 2 checks passed
@jellydn
Copy link
Contributor

jellydn commented Feb 26, 2024

@all-contributors add @nisalVD for doc.

Copy link
Contributor

@jellydn

I've put up a pull request to add @nisalVD! 🎉

@@ -53,7 +53,7 @@ return {
end,
event = "VeryLazy",
keys = {
{ "<leader>ccb", "<cmd>CopilotChatBuffer<cr>", desc = "CopilotChat - Chat with current buffer" },
Copy link

@MikaelElkiaer MikaelElkiaer Feb 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that <cmd> should be changed to : for the keys now missing the concluding <cr> - at least I got an error in neovim version NVIM v0.10.0-dev-2457+ga4b444252.

Copy link
Contributor Author

@nisalVD nisalVD Feb 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea you are right, it should be that

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for just dropping a comment instead of a PR, hoping it was better to leave a comment than nothing. :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MikaelElkiaer made a new PR with that change #88

Copy link
Contributor Author

@nisalVD nisalVD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should be that

@adrien-barret
Copy link

don't know it's juste a command problem. I have the same code error and I launched the command via : in nvim

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants