fix(blocklist): Follow up fixes for the blocklist plugin #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
JensDallmann
commented
Oct 24, 2023
•
JensDallmann
commented
- Allow letters which are not only between a-z/A-Z to support all languages.
- Cut off words/text which is too long in balloon.
- Improve initial balloon state when a word/text is selected.
…ithout separator If joined comma separated the comma is interpreted as part of the blocked words.
…ing in the editor.
…eyboard shortcut.
JensDallmann
force-pushed
the
fix/blocklist-special-character-support
branch
from
b9142cb to
788bc80
Compare
…limitations Storing the blocked word in the marker name has the pitfall that marker names may have limitations which are hard to foresee. One limitation is that `,` are not allowed in marker names. A sentence containing `,` would cause a console error and can't be blocked. Therefore, store the blocked word with the id as a reference.
JensDallmann
changed the base branch from
main
to
feature/bbcode-dataprocessor
mmichaelis
added
feature:blocklist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.