Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix logging typo #217

Merged
merged 1 commit into from
Jun 6, 2024
Merged

Fix logging typo #217

merged 1 commit into from
Jun 6, 2024

Conversation

tgenin
Copy link
Contributor

@tgenin tgenin commented Jun 4, 2024

s/from_cacke/from_cache

ldeflandre
ldeflandre previously approved these changes Jun 4, 2024
View reviewed changes
Copy link
Contributor

@ldeflandre ldeflandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Such a relief !
Thank you it was hurting every time I saw this log ;)

@antoinejeannot antoinejeannot dismissed ldeflandre’s stale review June 4, 2024 15:23

The merge-base changed after approval.

@tgenin tgenin force-pushed the fix-logging-typo branch from 4598126 to 2c87cf5 Compare June 6, 2024 12:53
@tgenin tgenin force-pushed the fix-logging-typo branch from 2c87cf5 to 51deb4f Compare June 6, 2024 13:30
antoinejeannot
antoinejeannot approved these changes Jun 6, 2024
View reviewed changes
Copy link
Contributor

@antoinejeannot antoinejeannot left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!! I was totally used to it, rip from cacke

@antoinejeannot antoinejeannot merged commit 454454c into Cornerstone-OnDemand:main Jun 6, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antoinejeannot antoinejeannot antoinejeannot approved these changes

@ldeflandre ldeflandre ldeflandre left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tgenin @ldeflandre @antoinejeannot