Improve backup check

Corsinvest · Nov 29, 2020 · 713e368 · 713e368
1 parent d02358e
commit 713e368
Show file tree

Hide file tree

Showing 4 changed files with 21 additions and 17 deletions.
diff --git a/.vscode/launch.json b/.vscode/launch.json
@@ -11,16 +11,7 @@
             "preLaunchTask": "build",
             // If you have changed target frameworks, make sure to update the program path.
             "program": "${workspaceFolder}/src/Corsinvest.ProxmoxVE.Diagnostic/bin/Debug/netcoreapp3.1/cv4pve-diag.dll",
-            "args": [
-                "--host",
-                "10.92.90.91",
-                "--username",
-                "test",
-                "--password",
-                "test",
-                "--output",
-                "text"
-            ],
+            "args": [],
             "cwd": "${workspaceFolder}/src/Corsinvest.ProxmoxVE.Diagnostic",
             // For more information about the 'console' field, see https://aka.ms/VSCode-CS-LaunchJson-Console
             "console": "internalConsole",

diff --git a/src/Corsinvest.ProxmoxVE.Diagnostic.Api/Application.cs b/src/Corsinvest.ProxmoxVE.Diagnostic.Api/Application.cs
@@ -784,8 +784,6 @@ private static void CheckQemu(ClusterInfo clusterInfo,
             }
         }
 
-
-
         private static void CheckCommonVm(ClusterInfo clusterInfo,
                                           List<DiagnosticResult> result,
                                           Settings settings,
@@ -799,8 +797,10 @@ private static void CheckCommonVm(ClusterInfo clusterInfo,
                                                           .Select(a => a.vmid))
                                                           .Split(',');
 
+            var allInBackup = clusterInfo.Backups.Any(a => a.enabled == 1 && a.all == 1);
+
             string vmId = vm.vmid.Value + "";
-            if (!vmsIdBackup.Contains(vmId))
+            if (!allInBackup && !vmsIdBackup.Contains(vmId))
             {
                 result.Add(new DiagnosticResult
                 {
@@ -813,6 +813,19 @@ private static void CheckCommonVm(ClusterInfo clusterInfo,
                 });
             }
 
+            //check disk no backup
+            result.AddRange(((List<(string Id, string Image)>)GetVmImages(vm))
+                                .Where(a => a.Image.Contains("backup=0"))
+                                .Select(a => new DiagnosticResult
+                                {
+                                    Id = vm.vmid,
+                                    ErrorCode = "WV0001",
+                                    Description = $"Disk '{a.Id}' disabled for backup",
+                                    Context = DiagnosticResultContext.Qemu,
+                                    SubContext = "Backup",
+                                    Gravity = DiagnosticResultGravity.Critical,
+                                }));
+
             //check exists backup and recent
             var regex = new Regex(@"^.*?:(.*?\/)?");
             var foundBackup = false;

diff --git a/src/Corsinvest.ProxmoxVE.Diagnostic.Api/Corsinvest.ProxmoxVE.Diagnostic.Api.csproj b/src/Corsinvest.ProxmoxVE.Diagnostic.Api/Corsinvest.ProxmoxVE.Diagnostic.Api.csproj
@@ -3,7 +3,7 @@
     <TargetFramework>netstandard2.1</TargetFramework>
     <GenerateDocumentationFile>true</GenerateDocumentationFile>
 
-    <Version>1.4.7</Version>
+    <Version>1.4.8</Version>
     <Company>Corsinvest Srl</Company>
     <Authors>Daniele Corsini</Authors>
     <Copyright>Corsinvest Srl</Copyright>

diff --git a/src/Corsinvest.ProxmoxVE.Diagnostic/Corsinvest.ProxmoxVE.Diagnostic.csproj b/src/Corsinvest.ProxmoxVE.Diagnostic/Corsinvest.ProxmoxVE.Diagnostic.csproj
@@ -1,7 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
   <PropertyGroup>
     <OutputType>Exe</OutputType>
-    <Version>1.3.6</Version>
+    <Version>1.3.7</Version>
     <TargetFramework>netcoreapp3.1</TargetFramework>
     <AssemblyName>cv4pve-diag</AssemblyName>
     <Company>Corsinvest Srl</Company>
@@ -20,9 +20,9 @@
     <TrimmerRootAssembly Include="System.Net.WebClient" />
 
     <!-- <ProjectReference Include="..\..\..\cv4pve-api-dotnet\src\Corsinvest.ProxmoxVE.Api.Shell\Corsinvest.ProxmoxVE.Api.Shell.csproj" /> -->
-    <PackageReference Include="Corsinvest.ProxmoxVE.Api.Shell" Version="2.6.7" />
+    <PackageReference Include="Corsinvest.ProxmoxVE.Api.Shell" Version="2.6.11" />
 
     <!-- <ProjectReference Include="..\Corsinvest.ProxmoxVE.Diagnostic.Api\Corsinvest.ProxmoxVE.Diagnostic.Api.csproj" /> -->
-    <PackageReference Include="Corsinvest.ProxmoxVE.Diagnostic.Api" Version="1.4.7" />
+    <PackageReference Include="Corsinvest.ProxmoxVE.Diagnostic.Api" Version="1.4.8" />
   </ItemGroup>
 </Project>