Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Impl non-generic non-custom on forwarding contract #266

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

jawoznia
Copy link
Collaborator

part of #263

@jawoznia jawoznia requested a review from hashedone November 22, 2023 15:02
@jawoznia jawoznia force-pushed the non_generic_non_custom_interface branch from 690c3f1 to 5f9ebea Compare November 22, 2023 15:03
Copy link

codecov bot commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (66287d2) 87.29% compared to head (6db65a2) 87.32%.

Additional details and impacted files
@@                     Coverage Diff                      @@
##           feat/generics_forwarding     #266      +/-   ##
============================================================
+ Coverage                     87.29%   87.32%   +0.02%     
============================================================
  Files                            25       25              
  Lines                          1811     1814       +3     
============================================================
+ Hits                           1581     1584       +3     
  Misses                          230      230              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@hashedone hashedone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jawoznia jawoznia force-pushed the custom_generic_interface branch from 401da3b to a6dd59d Compare November 23, 2023 13:00
@jawoznia jawoznia force-pushed the non_generic_non_custom_interface branch from 5f9ebea to 363037b Compare November 27, 2023 11:09
@jawoznia jawoznia force-pushed the custom_generic_interface branch from a6dd59d to 1e4c54a Compare November 27, 2023 11:19
@jawoznia jawoznia force-pushed the non_generic_non_custom_interface branch from 363037b to 1f8284e Compare November 27, 2023 11:20
@jawoznia jawoznia force-pushed the custom_generic_interface branch from 1e4c54a to 52eccee Compare November 30, 2023 14:29
Base automatically changed from custom_generic_interface to feat/generics_forwarding November 30, 2023 14:48
@jawoznia jawoznia force-pushed the non_generic_non_custom_interface branch from 1f8284e to 6db65a2 Compare November 30, 2023 14:49
@jawoznia jawoznia merged commit 20644c3 into feat/generics_forwarding Nov 30, 2023
7 checks passed
@jawoznia jawoznia deleted the non_generic_non_custom_interface branch November 30, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants