feat: Remove types forwarding to interface in sv::messages #361

kulikthebird · 2024-04-22T06:52:53Z

TODO:

JsonSchema implementation for contract's Exec, Query and Sudo message enums
Improve sylvia generated code's lifetimes names to avoid collisions

codecov · 2024-04-22T06:56:14Z

Codecov Report

Attention: Patch coverage is 98.96907% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 84.74%. Comparing base (f8c1e55) to head (5165301).

Files	Patch %	Lines
sylvia-derive/src/parser/attributes/messages.rs	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #361      +/-   ##
==========================================
+ Coverage   84.71%   84.74%   +0.02%     
==========================================
  Files          37       37              
  Lines        2598     2589       -9     
==========================================
- Hits         2201     2194       -7     
+ Misses        397      395       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

kulikthebird · 2024-04-22T14:50:13Z

There are Json and TS API generated for the sylvia/examples/contracts/generic_contract:

execute.json
GenericContract.client.txt
GenericContract.types.txt

examples/contracts/generic_contract/src/contract.rs

sylvia-derive/src/message.rs

examples/contracts/generic_contract/src/bin/schema.rs

examples/contracts/generic_contract/src/generic.rs

sylvia-derive/src/interfaces.rs

jawoznia

One more thing: Update MIGRATING.md.
I think two changes have to be mentioned which are required lifetimes in impl block and CodeId generic over a Contract.

Otherwise LGTM

jawoznia

Last small changes otherwise LGTM.

Basically do not link changes with specific feature as MIGRATING is supposed to group all the changes to specific version migration.

MIGRATING.md

## 🤖 New release * `sylvia`: 1.0.2 -> 1.1.0 * `sylvia-derive`: 1.0.2 -> 1.1.0 <details><summary>Changelog</summary> ## `sylvia-derive` <blockquote> ## [1.1.0](sylvia-derive-v1.0.2...sylvia-derive-v1.1.0) - 2024-07-12 ### Added - `From` implementation for contract messages of interface messages ([#391](#391)) - Attributes forwarding to message enums and fields ([#388](#388)) - Executors ([#386](#386)) - No ref needed for 'dyn Interface' type in Remote and BoundQuerier ([#382](#382)) - Remove types forwarding to interface in sv::messages ([#361](#361)) ### Other - Update documentation and refactoring ([#393](#393)) - Add trybuild check for two instantiate methods ([#392](#392)) - Update dependecies - Update proc-macro-crate deps </blockquote> </details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/). --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Tomasz Kulik <[email protected]>

## 🤖 New release * `sylvia`: 1.0.2 -> 1.1.0 * `sylvia-derive`: 1.0.2 -> 1.1.0 <details><summary>Changelog</summary> ## `sylvia-derive` <blockquote> ## [1.1.0](CosmWasm/sylvia@sylvia-derive-v1.0.2...sylvia-derive-v1.1.0) - 2024-07-12 ### Added - `From` implementation for contract messages of interface messages ([#391](CosmWasm/sylvia#391)) - Attributes forwarding to message enums and fields ([#388](CosmWasm/sylvia#388)) - Executors ([#386](CosmWasm/sylvia#386)) - No ref needed for 'dyn Interface' type in Remote and BoundQuerier ([#382](CosmWasm/sylvia#382)) - Remove types forwarding to interface in sv::messages ([#361](CosmWasm/sylvia#361)) ### Other - Update documentation and refactoring ([#393](CosmWasm/sylvia#393)) - Add trybuild check for two instantiate methods ([#392](CosmWasm/sylvia#392)) - Update dependecies - Update proc-macro-crate deps </blockquote> </details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/). --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Tomasz Kulik <[email protected]>

kulikthebird linked an issue Apr 22, 2024 that may be closed by this pull request

#[sv::messages] does not need generics to be forwarded to interfaces with associated types #350

Closed

kulikthebird mentioned this pull request Apr 22, 2024

feat: No need to pass types to non-generic interfaces #358

Closed

kulikthebird force-pushed the tkulik/feat/no_generics_for_interfaces branch 2 times, most recently from 559a06a to 5132a69 Compare April 22, 2024 07:58

kulikthebird marked this pull request as ready for review April 22, 2024 07:59

kulikthebird force-pushed the tkulik/feat/no_generics_for_interfaces branch 6 times, most recently from dfdad2e to 371aa34 Compare April 22, 2024 13:58

kulikthebird changed the title ~~feat: Remove types forwarding to interface's assoc~~ feat: Remove types forwarding to interface in sv::messages Apr 22, 2024

kulikthebird force-pushed the tkulik/feat/no_generics_for_interfaces branch from 371aa34 to 69f59e2 Compare April 23, 2024 06:30

kulikthebird requested review from hashedone and jawoznia April 23, 2024 06:33

jawoznia reviewed Apr 23, 2024

View reviewed changes

examples/contracts/generic_contract/src/bin/schema.rs Show resolved Hide resolved

examples/contracts/generic_contract/src/generic.rs Show resolved Hide resolved

sylvia-derive/src/interfaces.rs Show resolved Hide resolved

kulikthebird mentioned this pull request Apr 23, 2024

Remove InterfaceApi in favor of InterfaceMessagesApi #363

Closed

kulikthebird force-pushed the tkulik/feat/no_generics_for_interfaces branch from b65c660 to c4fdf15 Compare April 23, 2024 18:26

kulikthebird added 2 commits May 6, 2024 10:13

feat: Remove types forwarding to interface in sv::messages

f283075

chore: Update after review

dc8747a

kulikthebird force-pushed the tkulik/feat/no_generics_for_interfaces branch from c4fdf15 to dc8747a Compare May 6, 2024 08:14

kulikthebird requested a review from jawoznia May 6, 2024 08:35

jawoznia approved these changes May 6, 2024

View reviewed changes

kulikthebird force-pushed the tkulik/feat/no_generics_for_interfaces branch from 65bd4ef to 1620583 Compare May 7, 2024 09:05

jawoznia approved these changes May 7, 2024

View reviewed changes

MIGRATING.md Outdated Show resolved Hide resolved

MIGRATING.md Outdated Show resolved Hide resolved

MIGRATING.md Outdated Show resolved Hide resolved

MIGRATING.md Outdated Show resolved Hide resolved

kulikthebird commented May 7, 2024

View reviewed changes

MIGRATING.md Outdated Show resolved Hide resolved

docs: Update MIGRATING.md

5165301

kulikthebird force-pushed the tkulik/feat/no_generics_for_interfaces branch from 1620583 to 5165301 Compare May 7, 2024 09:18

kulikthebird enabled auto-merge (squash) May 7, 2024 09:21

kulikthebird merged commit 741b358 into main May 7, 2024
7 checks passed

kulikthebird deleted the tkulik/feat/no_generics_for_interfaces branch May 7, 2024 09:30

github-actions bot mentioned this pull request May 7, 2024

chore: release #366

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Remove types forwarding to interface in sv::messages #361

feat: Remove types forwarding to interface in sv::messages #361

kulikthebird commented Apr 22, 2024 •

edited

Loading

codecov bot commented Apr 22, 2024 •

edited

Loading

kulikthebird commented Apr 22, 2024

jawoznia left a comment

jawoznia left a comment

feat: Remove types forwarding to interface in sv::messages #361

feat: Remove types forwarding to interface in sv::messages #361

Conversation

kulikthebird commented Apr 22, 2024 • edited Loading

codecov bot commented Apr 22, 2024 • edited Loading

Codecov Report

kulikthebird commented Apr 22, 2024

jawoznia left a comment

Choose a reason for hiding this comment

jawoznia left a comment

Choose a reason for hiding this comment

kulikthebird commented Apr 22, 2024 •

edited

Loading

codecov bot commented Apr 22, 2024 •

edited

Loading