Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add trybuild check for two instantiate methods #392

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

kulikthebird
Copy link
Contributor

@kulikthebird kulikthebird commented Jul 3, 2024

No description provided.

Copy link

codecov bot commented Jul 3, 2024

Codecov Report

Attention: Patch coverage is 62.50000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 85.45%. Comparing base (0cec90b) to head (ef7c08c).

Files Patch % Lines
sylvia-derive/src/input.rs 62.50% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #392      +/-   ##
==========================================
- Coverage   85.82%   85.45%   -0.38%     
==========================================
  Files          40       40              
  Lines        2865     2880      +15     
==========================================
+ Hits         2459     2461       +2     
- Misses        406      419      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kulikthebird kulikthebird force-pushed the tkulik/chore/errors_instantiate branch from 4d33d1b to 6f537cc Compare July 3, 2024 17:12
Copy link
Collaborator

@jawoznia jawoznia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kulikthebird kulikthebird force-pushed the tkulik/chore/errors_instantiate branch from 6f537cc to ef7c08c Compare July 9, 2024 07:07
@kulikthebird kulikthebird enabled auto-merge (squash) July 9, 2024 07:11
@kulikthebird kulikthebird merged commit 3ab2a01 into main Jul 9, 2024
5 of 7 checks passed
@kulikthebird kulikthebird deleted the tkulik/chore/errors_instantiate branch July 9, 2024 07:19
@github-actions github-actions bot mentioned this pull request Jul 8, 2024
kulikthebird added a commit that referenced this pull request Jul 12, 2024
## 🤖 New release
* `sylvia`: 1.0.2 -> 1.1.0
* `sylvia-derive`: 1.0.2 -> 1.1.0

<details><summary><i><b>Changelog</b></i></summary><p>

## `sylvia-derive`
<blockquote>

##
[1.1.0](sylvia-derive-v1.0.2...sylvia-derive-v1.1.0)
- 2024-07-12

### Added
- `From` implementation for contract messages of interface messages
([#391](#391))
- Attributes forwarding to message enums and fields
([#388](#388))
- Executors ([#386](#386))
- No ref needed for 'dyn Interface' type in Remote and BoundQuerier
([#382](#382))
- Remove types forwarding to interface in sv::messages
([#361](#361))

### Other
- Update documentation and refactoring
([#393](#393))
- Add trybuild check for two instantiate methods
([#392](#392))
- Update dependecies
- Update proc-macro-crate deps
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/MarcoIeni/release-plz/).

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Tomasz Kulik <[email protected]>
blaze00193 pushed a commit to blaze00193/CosmWasm-smart-contract that referenced this pull request Sep 26, 2024
## 🤖 New release
* `sylvia`: 1.0.2 -> 1.1.0
* `sylvia-derive`: 1.0.2 -> 1.1.0

<details><summary><i><b>Changelog</b></i></summary><p>

## `sylvia-derive`
<blockquote>

##
[1.1.0](CosmWasm/sylvia@sylvia-derive-v1.0.2...sylvia-derive-v1.1.0)
- 2024-07-12

### Added
- `From` implementation for contract messages of interface messages
([#391](CosmWasm/sylvia#391))
- Attributes forwarding to message enums and fields
([#388](CosmWasm/sylvia#388))
- Executors ([#386](CosmWasm/sylvia#386))
- No ref needed for 'dyn Interface' type in Remote and BoundQuerier
([#382](CosmWasm/sylvia#382))
- Remove types forwarding to interface in sv::messages
([#361](CosmWasm/sylvia#361))

### Other
- Update documentation and refactoring
([#393](CosmWasm/sylvia#393))
- Add trybuild check for two instantiate methods
([#392](CosmWasm/sylvia#392))
- Update dependecies
- Update proc-macro-crate deps
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/MarcoIeni/release-plz/).

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Tomasz Kulik <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assert exactly one instantiate message is defined Test error messages with Trybuild
2 participants