Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Emit error if contract macro is above entry_points #408

Merged
merged 3 commits into from
Jul 31, 2024

Conversation

jawoznia
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@hashedone hashedone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good error.

Copy link

codecov bot commented Jul 31, 2024

Codecov Report

Attention: Patch coverage is 0% with 19 lines in your changes missing coverage. Please review.

Project coverage is 85.01%. Comparing base (d1052d5) to head (e2c4bfa).

Files Patch % Lines
sylvia-derive/src/input.rs 0.00% 15 Missing ⚠️
sylvia-derive/src/lib.rs 0.00% 2 Missing ⚠️
sylvia-derive/src/message.rs 0.00% 1 Missing ⚠️
sylvia-derive/src/parser/entry_point.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #408      +/-   ##
==========================================
- Coverage   85.33%   85.01%   -0.33%     
==========================================
  Files          42       42              
  Lines        2905     2916      +11     
==========================================
  Hits         2479     2479              
- Misses        426      437      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from jawoznia/entry_points_errors to main July 31, 2024 14:03
@jawoznia jawoznia force-pushed the jawoznia/error_if_entry_points_below_contract branch from 9e5e62f to e2c4bfa Compare July 31, 2024 14:25
@jawoznia jawoznia merged commit df2fece into main Jul 31, 2024
7 of 9 checks passed
@jawoznia jawoznia deleted the jawoznia/error_if_entry_points_below_contract branch July 31, 2024 14:52
@jawoznia
Copy link
Collaborator Author

jawoznia commented Aug 1, 2024

#397

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants