Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Setup new directory structure #411

Merged
merged 2 commits into from
Aug 6, 2024
Merged

Conversation

jawoznia
Copy link
Collaborator

@jawoznia jawoznia commented Aug 5, 2024

No description provided.

@jawoznia jawoznia requested a review from kulikthebird August 5, 2024 17:07
Copy link

codecov bot commented Aug 5, 2024

Codecov Report

Attention: Patch coverage is 80.21638% with 256 lines in your changes missing coverage. Please review.

Project coverage is 82.37%. Comparing base (059bf84) to head (b5baddd).

Files Patch % Lines
sylvia-derive/src/entry_points.rs 0.00% 102 Missing ⚠️
sylvia-derive/src/parser/interface.rs 0.00% 102 Missing ⚠️
sylvia-derive/src/interface.rs 78.43% 22 Missing ⚠️
sylvia-derive/src/interface/mt.rs 92.56% 11 Missing ⚠️
...ia-derive/src/contract/communication/struct_msg.rs 89.01% 10 Missing ⚠️
sylvia-derive/src/types/msg_field.rs 93.61% 3 Missing ⚠️
sylvia-derive/src/types/msg_variant.rs 97.82% 3 Missing ⚠️
...a-derive/src/contract/communication/wrapper_msg.rs 98.41% 2 Missing ⚠️
sylvia-derive/src/contract.rs 98.64% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #411      +/-   ##
==========================================
- Coverage   85.05%   82.37%   -2.69%     
==========================================
  Files          42       53      +11     
  Lines        2924     3126     +202     
==========================================
+ Hits         2487     2575      +88     
- Misses        437      551     +114     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jawoznia jawoznia force-pushed the jawoznia/structure_refactor branch from 3f2a751 to 940c79d Compare August 5, 2024 17:17
Base automatically changed from jawoznia/fix_attr_on_struct to main August 6, 2024 13:45
Copy link
Contributor

@kulikthebird kulikthebird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good change, definitely a step in the right direction. I like the separation between the three types of macros that Sylvia defines. Let's consider this a first step and look to add further distinctions between the new modules, especially the parsers.

@jawoznia jawoznia force-pushed the jawoznia/structure_refactor branch from 85226a8 to b5baddd Compare August 6, 2024 13:54
@jawoznia jawoznia merged commit a83ccac into main Aug 6, 2024
7 of 9 checks passed
@jawoznia jawoznia deleted the jawoznia/structure_refactor branch August 6, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants