Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Refactor MsgAttr #434

Merged
merged 2 commits into from
Sep 17, 2024
Merged

Conversation

jawoznia
Copy link
Collaborator

@jawoznia jawoznia commented Sep 2, 2024

No description provided.

Copy link

codecov bot commented Sep 2, 2024

Codecov Report

Attention: Patch coverage is 88.57143% with 4 lines in your changes missing coverage. Please review.

Project coverage is 69.88%. Comparing base (71e5a76) to head (15164b7).
Report is 2 commits behind head on feat/replies.

Files with missing lines Patch % Lines
sylvia-derive/src/types/msg_type.rs 72.72% 3 Missing ⚠️
sylvia-derive/src/parser/attributes/mod.rs 66.66% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           feat/replies     #434      +/-   ##
================================================
+ Coverage         69.83%   69.88%   +0.04%     
================================================
  Files                54       54              
  Lines              3120     3125       +5     
================================================
+ Hits               2179     2184       +5     
  Misses              941      941              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@kulikthebird kulikthebird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Base automatically changed from jawoznia/feat/parse_msg_reply to feat/replies September 17, 2024 12:17
Remove redundancy between `MsgAttr` and `MsgType`
@jawoznia jawoznia force-pushed the jawoznia/chore/msg_attr_refactor branch from 76ceb1f to 15164b7 Compare September 17, 2024 12:19
@jawoznia jawoznia merged commit 778c5f0 into feat/replies Sep 17, 2024
9 checks passed
@jawoznia jawoznia deleted the jawoznia/chore/msg_attr_refactor branch September 17, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants