Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Pass payload while building SubMsg #442

Merged

Conversation

jawoznia
Copy link
Collaborator

@jawoznia jawoznia commented Oct 10, 2024

close #441

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 83.21678% with 24 lines in your changes missing coverage. Please review.

Project coverage is 72.18%. Comparing base (fb86aaa) to head (61f1e0f).
Report is 3 commits behind head on feat/replies.

Files with missing lines Patch % Lines
sylvia-derive/src/contract/communication/reply.rs 82.22% 24 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           feat/replies     #442      +/-   ##
================================================
- Coverage         72.41%   72.18%   -0.24%     
================================================
  Files                56       56              
  Lines              3542     3577      +35     
================================================
+ Hits               2565     2582      +17     
- Misses              977      995      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jawoznia jawoznia force-pushed the jawoznia/feat/pass_payload_while_creating_submsg branch from a817154 to e3ad0e3 Compare October 11, 2024 14:17
@jawoznia jawoznia marked this pull request as ready for review October 11, 2024 14:18
@jawoznia jawoznia force-pushed the jawoznia/feat/deserialize_payload branch from c5ee0d8 to d9b3a63 Compare October 11, 2024 14:36
@jawoznia jawoznia force-pushed the jawoznia/feat/pass_payload_while_creating_submsg branch from e3ad0e3 to f7b63d7 Compare October 11, 2024 14:37
Copy link
Contributor

@kulikthebird kulikthebird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

.remote_instantiated()
.with_payload(to_json_binary(&payload)?);
.remote_instantiated(to_json_binary(&payload)?)?;
// Blocked by https://github.com/CosmWasm/cw-multi-test/pull/216.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a TODO mark and URL to an issue that will solve this blocked part

sylvia/tests/ui/method_signature/reply.rs Outdated Show resolved Hide resolved
sylvia-derive/src/contract/communication/reply.rs Outdated Show resolved Hide resolved
sylvia/tests/ui/method_signature/reply.rs Show resolved Hide resolved
sylvia/tests/ui/method_signature/reply.rs Outdated Show resolved Hide resolved
Base automatically changed from jawoznia/feat/deserialize_payload to feat/replies October 14, 2024 09:14
@jawoznia jawoznia force-pushed the jawoznia/feat/pass_payload_while_creating_submsg branch 3 times, most recently from df259f2 to f7b63d7 Compare October 14, 2024 09:24
@jawoznia jawoznia force-pushed the jawoznia/feat/pass_payload_while_creating_submsg branch from f7b63d7 to 7554c9f Compare October 14, 2024 09:26
@jawoznia jawoznia force-pushed the jawoznia/feat/pass_payload_while_creating_submsg branch from 015b707 to 61f1e0f Compare October 14, 2024 10:49
Copy link
Contributor

@kulikthebird kulikthebird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@jawoznia jawoznia merged commit d43909d into feat/replies Oct 14, 2024
9 checks passed
@jawoznia jawoznia deleted the jawoznia/feat/pass_payload_while_creating_submsg branch October 14, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants