Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove sv_replies feature as it does not prevent semver breaking #444

Closed
wants to merge 1 commit into from

Conversation

jawoznia
Copy link
Collaborator

No description provided.

@jawoznia jawoznia force-pushed the jawoznia/feat/remove_reply_feature branch from 747906e to a23a5c3 Compare October 14, 2024 10:44
Copy link

codecov bot commented Oct 14, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 72.01%. Comparing base (d43909d) to head (85739f3).

Files with missing lines Patch % Lines
sylvia-derive/src/entry_points.rs 0.00% 5 Missing ⚠️
sylvia-derive/src/contract/mt.rs 0.00% 3 Missing ⚠️
sylvia/tests/messages_generation.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           feat/replies     #444      +/-   ##
================================================
- Coverage         72.18%   72.01%   -0.17%     
================================================
  Files                56       57       +1     
  Lines              3577     3584       +7     
================================================
- Hits               2582     2581       -1     
- Misses              995     1003       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jawoznia jawoznia force-pushed the jawoznia/feat/pass_payload_while_creating_submsg branch from 015b707 to 61f1e0f Compare October 14, 2024 10:49
@jawoznia jawoznia force-pushed the jawoznia/feat/remove_reply_feature branch from a23a5c3 to 512d994 Compare October 14, 2024 10:50
Base automatically changed from jawoznia/feat/pass_payload_while_creating_submsg to feat/replies October 14, 2024 12:22
@jawoznia jawoznia force-pushed the jawoznia/feat/remove_reply_feature branch from 512d994 to 85739f3 Compare October 14, 2024 12:22
@jawoznia
Copy link
Collaborator Author

closing in favor of #446

@jawoznia jawoznia closed this Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant