Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Better reply support (#418) #452

Merged
merged 43 commits into from
Nov 20, 2024

chore: Minor tweaks

97fc158
Select commit
Loading
Failed to load commit list.
Merged

feat: Better reply support (#418) #452

chore: Minor tweaks
97fc158
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 20, 2024 in 0s

71.95% (+1.87%) compared to 10e8eb9

View this Pull Request on Codecov

71.95% (+1.87%) compared to 10e8eb9

Details

Codecov Report

Attention: Patch coverage is 79.33025% with 179 lines in your changes missing coverage. Please review.

Project coverage is 71.95%. Comparing base (10e8eb9) to head (97fc158).

Files with missing lines Patch % Lines
sylvia-derive/src/contract/communication/reply.rs 86.02% 52 Missing ⚠️
sylvia/tests/reply_generation.rs 0.00% 14 Missing ⚠️
sylvia-derive/src/parser/mod.rs 36.84% 12 Missing ⚠️
sylvia/src/builder/instantiate.rs 47.82% 12 Missing ⚠️
sylvia-derive/src/parser/attributes/msg.rs 78.43% 11 Missing ⚠️
sylvia/src/ctx.rs 35.29% 11 Missing ⚠️
sylvia-derive/src/parser/attributes/data.rs 62.96% 10 Missing ⚠️
sylvia-derive/src/entry_points.rs 0.00% 8 Missing ⚠️
sylvia-derive/src/parser/attributes/payload.rs 50.00% 8 Missing ⚠️
sylvia/tests/remote.rs 63.63% 8 Missing ⚠️
... and 10 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #452      +/-   ##
==========================================
+ Coverage   70.08%   71.95%   +1.87%     
==========================================
  Files          53       63      +10     
  Lines        3085     3879     +794     
==========================================
+ Hits         2162     2791     +629     
- Misses        923     1088     +165

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

View more details on Codecov