Skip to content

Commit

Permalink
Merge pull request #4 from eyezahhhh/main
Browse files Browse the repository at this point in the history
fix callback
  • Loading branch information
eyezahhhh authored Oct 25, 2022
2 parents c1576b1 + 2a999bc commit 0cb6055
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions src/Scene.js
Original file line number Diff line number Diff line change
Expand Up @@ -89,15 +89,15 @@ class Scene {


let awaitingComponents = [];
function checkCompletion(id) {
function checkCompletion(instance, id) {
let index = awaitingComponents.indexOf(id);
if (index >= 0) awaitingComponents.splice(index, 1);
if (!awaitingComponents.length && options.readyCallback) options.readyCallback(this);
if (!awaitingComponents.length && options.readyCallback) options.readyCallback(instance);
}

if (options.panorama) {
awaitingComponents.push("panorama");
this.setPanorama(options.panorama, options.fixedPanorama).then(()=> checkCompletion("panorama"));
this.setPanorama(options.panorama, options.fixedPanorama).then(()=> checkCompletion(this, "panorama"));
}
if (options.canvas) {
this.renderer = new THREE.WebGLRenderer({
Expand Down Expand Up @@ -135,7 +135,7 @@ class Scene {
}
animate(this, options.renderCallback);
}
if (!awaitingComponents.length) checkCompletion();
if (!awaitingComponents.length) checkCompletion(this);
}


Expand Down

0 comments on commit 0cb6055

Please sign in to comment.