fix code issues

Cosmic-Ide · May 10, 2022 · 3a7e4cd · 3a7e4cd
1 parent 455b227
commit 3a7e4cd
Show file tree

Hide file tree

Showing 7 changed files with 21 additions and 30 deletions.
diff --git a/.github/ISSUE_TEMPLATE/bug_report.md b/.github/ISSUE_TEMPLATE/bug_report.md
@@ -12,6 +12,7 @@ A clear and concise description of what the bug is.
 
 **To Reproduce**
 Steps to reproduce the behavior:
+
 1. Go to '...'
 2. Click on '....'
 3. Scroll down to '....'
@@ -24,6 +25,7 @@ A clear and concise description of what you expected to happen.
 If applicable, add screenshots to help explain your problem.
 
 **Mobile phone (please complete the following information):**
+
 - Device: [e.g. Pixel 6]
 - OS: [e.g. Android 12]
 - Version [e.g. v0.0.3]

diff --git a/README.md b/README.md
@@ -3,15 +3,12 @@
 [![Android CI](https://github.com/PranavPurwar/Java-Ide/actions/workflows/android.yml/badge.svg)](https://github.com/PranavPurwar/Java-Ide/actions/workflows/android.yml)
 [![Discord Server](https://img.shields.io/badge/chat-on%20discord-7289da)](https://discord.gg/8Gu6YCq2eS)
 
-<div align='center'>
+Compile and test your java code anytime anywhere from your mobile phone
 
-  Compile and test your java code anytime anywhere from your mobile phone
+## How to get
 
-</div>
-
-## How to get?
-
-You can get the latest release from [here](https://github.com/PranavPurwar/Java-Ide/releases) and latest debug build from [Github Actions](https://github.com/PranavPurwar/Java-Ide/actions).
+You can get the latest release from [here](https://github.com/PranavPurwar/Java-Ide/releases)
+and the latest debug build from [Github Actions](https://github.com/PranavPurwar/Java-Ide/actions).
 
 ## Features
 
@@ -43,17 +40,19 @@ You can get the latest release from [here](https://github.com/PranavPurwar/Java-
 ## Building
 
 Clone this repository on your device and compile using Android Studio or by running the command
-```
+
+```sh
 ./gradlew build
 ```
 
 ## Contributing
 
-I would really appreciate all kinds of contributions. If you have any questions, ideas, need help or want to propose a change just open an issue.
+I would really appreciate all kinds of contributions.
+If you have any questions, ideas, need help or want to propose a change just open an issue.
 
 - Contributions are highly appreciated.
 - Create a pull request and we'll merge it after thorough review.
- 
+
 ## Special thanks
 
 - [TheWolf](https://github.com/thewolfprod)

diff --git a/app/src/main/java/com/pranav/java/ide/SettingActivity.java b/app/src/main/java/com/pranav/java/ide/SettingActivity.java
@@ -35,8 +35,6 @@ public final class SettingActivity extends AppCompatActivity {
     private AlertDialog alertDialog;
     private SharedPreferences settings;
 
-    private String TAG = "SettingsActivity";
-
     @Override
     protected void onCreate(Bundle savedInstanceState) {
         super.onCreate(savedInstanceState);

diff --git a/lib-android/src/main/java/com/pranav/lib_android/task/java/JavacCompilationTask.java b/lib-android/src/main/java/com/pranav/lib_android/task/java/JavacCompilationTask.java
@@ -155,7 +155,7 @@ public List<File> getClasspath() {
         final String clspath = prefs.getString("classpath", "");
 
         if (!clspath.isEmpty()) {
-            for (String clas : clspath.toString().split(":")) {
+            for (String clas : clspath.split(":")) {
                 classpath.add(new File(clas));
             }
         }

diff --git a/...oogle-java-format/src/main/java/com/google/googlejavaformat/java/JavaInputAstVisitor.java b/...oogle-java-format/src/main/java/com/google/googlejavaformat/java/JavaInputAstVisitor.java
@@ -1782,10 +1782,7 @@ private boolean ambiguousUnaryOperator(UnaryTree node, String operatorName) {
         if (tag.isPostUnaryOp()) {
             return false;
         }
-        if (!operatorName(node).startsWith(operatorName)) {
-            return false;
-        }
-        return true;
+        return operatorName(node).startsWith(operatorName);
     }
 
     private JCTree.Tag unaryTag(ExpressionTree expression) {

diff --git a/lib-google-java-format/src/main/java/com/google/googlejavaformat/java/JavaOutput.java b/lib-google-java-format/src/main/java/com/google/googlejavaformat/java/JavaOutput.java
@@ -163,16 +163,14 @@ public void append(String text, Range<Integer> range) {
                             spacesPending = new StringBuilder();
                         }
                         lineBuilder.append(c);
-                        if (!range.isEmpty()) {
-                            if (!rangesSet) {
-                                while (ranges.size() <= mutableLines.size()) {
-                                    ranges.add(Formatter.EMPTY_RANGE);
-                                }
-                                ranges.set(
-                                        mutableLines.size(),
-                                        union(ranges.get(mutableLines.size()), range));
-                                rangesSet = true;
+                        if (!range.isEmpty() && !rangesSet) {
+                            while (ranges.size() <= mutableLines.size()) {
+                                ranges.add(Formatter.EMPTY_RANGE);
                             }
+                            ranges.set(
+                                    mutableLines.size(),
+                                    union(ranges.get(mutableLines.size()), range));
+                            rangesSet = true;
                         }
                 }
             }

diff --git a/...oogle-java-format/src/main/java/com/google/googlejavaformat/java/RemoveUnusedImports.java b/...oogle-java-format/src/main/java/com/google/googlejavaformat/java/RemoveUnusedImports.java
@@ -330,10 +330,7 @@ private static boolean isUnused(
         if (usedNames.contains(simpleName)) {
             return false;
         }
-        if (usedInJavadoc.containsKey(simpleName)) {
-            return false;
-        }
-        return true;
+        return !usedInJavadoc.containsKey(simpleName);
     }
 
     /** Applies the replacements to the given source, and re-format any edited javadoc. */