Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draft: WaveDiff: New PSF Model Features, Refactoring, and PEP8 Compliance #142

Open
wants to merge 235 commits into
base: develop
Choose a base branch
from
Open

Draft: WaveDiff: New PSF Model Features, Refactoring, and PEP8 Compliance #142

wants to merge 235 commits into from

Conversation

jeipollack
Copy link
Contributor

@jeipollack jeipollack commented Feb 5, 2025 •
edited
Loading

This PR includes new features:

  • Including PSF model extension with physical layer for a Zernike prior (Closes Implement PSF model with a physical layer #123)
  • Centroid Estimation correction (Closes Optimise WaveDiff to address Centroid problem #113)
  • CCD z-axis misalignment model correction
  • Add module for simulating spatially-varying PSFs and validation tests
  • Add phase retrieval and validation tests
  • Replacing TrainingDataHandler and TestDataHandler with a single DataHandler class
  • Renaming variables, functions, and classes following PEP8 naming conventions
  • Removal of deprecated code

@tobias-liaudat
add dev configs
625d135
@tobias-liaudat
config for fast test
6e88956
@tobias-liaudat
fix configs
38b0f34
@tobias-liaudat
update (fix) configs
9e67e91
@tobias-liaudat
try again
d16cd72
@tobias-liaudat
fix config problem
a2f64a0
@tobias-liaudat
Merge branch 'develop' of https://github.com/CosmoStat/wf-psf into u/…
e45df03 
…tobias-liaudat/feature-phase_retrieval
@tobias-liaudat
Add new Zernike projection function with obscurations
bb9cba1
@tobias-liaudat
Add new Zk projection algorithm
edccc88
@tobias-liaudat
Add default behaviour
f3ee49d
@tobias-liaudat
Improve comments and doc
7838cca
@tobias-liaudat
Fix problem with repeating seed for S init after projection
5ee00bc
@tobias-liaudat
Fix small bug when random seed is not defined
08c0aad
@tobias-liaudat
Add phase retrieval test configs
20dcfdb
@tobias-liaudat
update dev configs
72e6f69
@tobias-liaudat
Add job for PR validation
51e8b65
@tobias-liaudat
Add log dir
9b5e817
@tobias-liaudat
Update configs
e03a34f
@tobias-liaudat
update job
f60dcaf
@tobias-liaudat
Add new configs and job in new dir
b1a4c1b
@tobias-liaudat
debug lines
c7d2914
@tobias-liaudat
try bug fix
9eef69b
@tobias-liaudat
add new test
a1dc1da
@tobias-liaudat
fix paths
bce7c9b
@tobias-liaudat
erase debug lines
51d0d6d
@tobias-liaudat
fix another path
12598d8
@tobias-liaudat
update paths
00faa96
@tobias-liaudat
remove unused configs
d200f07
@tobias-liaudat
Add plot all config
d50b647
@tobias-liaudat
fix job
a5b3f5c
tobias-liaudat and others added 26 commits April 7, 2024 22:28
@tobias-liaudat
add new input to get zernikes
51244e0
@tobias-liaudat
Add handling of centroid / CCD missalignments / zernike priors
82d352f
@tobias-liaudat
simplify code
f3cc666
@tobias-liaudat
factorise code
e272e33
@tobias-liaudat
add handling of parameters from training config
3ad33f4
@tobias-liaudat
get parameters from model_params and not data.simPSF
643a283
@tobias-liaudat
add new inputs to training config
3f7a057
@tobias-liaudat
black formatting
064790d
@tobias-liaudat
fix typos in comments
e1fcfd3
@jeipollack
Refactor: change name of metric evaluation flags and provide options …
fe98783 
…for ground truth models
@jeipollack
Add logging for zernike contribution list
386c643
@jeipollack
Refactor: Correct typo in docstring and remove deprecated/unused code
0b51c66
@jeipollack
Refactor: replace ground truth psf model function with abstract get_p…
b9a498b 
…sf_model method and add iteration over metrics evaluation functions
@jeipollack
Replace not_equal conditional with tensorflow equivalent
b0b5a39
@jeipollack
Update interpolation_type docstring
b7abcc1
@jeipollack
Refactor: Add TFGroundTruthPhysicalField and TFGroundTruthSemiParamet…
6da6460 
…ricField to psf model registry
@jeipollack
Refactor: remove unneeded preprocess function and reformat with black
6639a74
@jeipollack
Reformat with black
995d6ea
@jeipollack
Add missing data_conf to method in MetricsConfigHandler class and ref…
e19018e 
…ormat with black
@jeipollack
Add use_prior flag to training_config.yaml
55646ad
@tobias-liaudat
Update the default value to Euclid expected value
26d2d8e
@tobias-liaudat
Add new parameter for the centroid window function
22fd33e
@tobias-liaudat
Propagate new window function parameter to centroid function
584889e
@tobias-liaudat
apply black formatting to project
5579c2f
@tobias-liaudat
fix type in docstring
160215b
@tobias-liaudat
fix typo in docstring
bfd1ef8
@jeipollack jeipollack added the enhancement New feature or request label Feb 5, 2025
@jeipollack jeipollack self-assigned this Feb 5, 2025
@jeipollack jeipollack changed the title Draft: WaveDiff Features Draft: WaveDiff: New PSF Model Features, Refactoring, and PEP8 Compliance Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jeipollack jeipollack

Labels
enhancement New feature or request
Projects
wavefront-based PSF model estimation
Status: No status
Milestone
Modelling Performance Enhancement
Development

Successfully merging this pull request may close these issues.
2 participants
@jeipollack @tobias-liaudat