fix! not loading in contracts with custom WasmVM after upgrade #961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reecepbcups
changed the title
Reecepbcups
changed the title
|
since juno190g5j8aszqhvtg7cprmev8xcxs6csra7xnk3n3 is not a vesting account anymore maybe we can just send balance witha a standard transaction instead of messing more with it |
|
@dimiandre I'm fine with that. Didn't know if Core-1 could get the votes. The first commit in this PR is from the release/v19 branch. So I can't remove that (v19.1.0) but will get the handler out if desired for v20 |
|
lets do the halt and patch |
Reecepbcups
requested review from
the-frey,
JakeHartnell,
jackzampolin,
dimiandre and
joelsmith-2019
as code owners
|
Can confirm v18 -> this branch works as expected with it. |
joelsmith-2019
pushed a commit
that referenced
this pull request
Feb 15, 2024
* fix!: load from the proper data dir * v20 plain upgrade * lintor * execute contract's before and after an upgrade * remove v20 storekey addition * CreateV20UpgradeHandler * remove v20 * fix upgrade test (v18 -> v19)
dimiandre
pushed a commit
that referenced
this pull request
Mar 2, 2024
…#968) * fix!: load from the proper data dir * v20 plain upgrade * lintor * execute contract's before and after an upgrade * remove v20 storekey addition * CreateV20UpgradeHandler * remove v20 * fix upgrade test (v18 -> v19) Co-authored-by: Reece Williams <[email protected]>
dimiandre
added a commit
that referenced
this pull request
Mar 2, 2024
* fix! not loading in contracts with custom WasmVM after upgrade (#961) * fix!: load from the proper data dir * v20 plain upgrade * lintor * execute contract's before and after an upgrade * remove v20 storekey addition * CreateV20UpgradeHandler * remove v20 * fix upgrade test (v18 -> v19) * Create v21 Namespace & Upgrade Handler * bump: golang-ci-lint-action (#974) * Bump golangci/golangci-lint-action from 3 to 4 Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action) from 3 to 4. - [Release notes](https://github.com/golangci/golangci-lint-action/releases) - [Commits](golangci/golangci-lint-action@v3...v4) --- updated-dependencies: - dependency-name: golangci/golangci-lint-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> * update lint action * do the easy stuff first.... --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * run upgrade test against v20 & remove wasm from store upgrades --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Reece Williams <[email protected]> Co-authored-by: Jacob Gadikian <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Andrea Di Michele <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref PR #960 for further information and debugging scripts
Will need to backport to main