Added a null check on while stoping a view to avoid potential issue. (#…

…19) * Added a null check on while stoping a view to avoid potential issue. * Update CHANGELOG.md Co-authored-by: ArtursKadikis <[email protected]>
Countly · Sep 1, 2022 · ba1f013 · ba1f013
1 parent 3cec3b1
commit ba1f013
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,6 @@
+20.11.4
+* Adding mitigations to an issue that would surface when stopping a view that was not started.
+
 20.11.3
 * Fixed a threading issue in the backend mode feature.
 

diff --git a/gradle.properties b/gradle.properties
@@ -18,7 +18,7 @@
 # org.gradle.parallel=true
 
 # RELEASE FIELD SECTION
-VERSION_NAME=20.11.3
+VERSION_NAME=20.11.4
 GROUP=ly.count.sdk
 
 POM_URL=https://github.com/Countly/countly-sdk-java

diff --git a/sdk-java/src/main/java/ly/count/sdk/java/Config.java b/sdk-java/src/main/java/ly/count/sdk/java/Config.java
@@ -265,7 +265,7 @@ public boolean restore(byte[] data) {
     /**
      * Countly SDK version to be sent in HTTP requests
      */
-    protected String sdkVersion = "20.11.3";
+    protected String sdkVersion = "20.11.4";
 
     /**
      * Countly SDK name to be sent in HTTP requests

diff --git a/sdk-java/src/main/java/ly/count/sdk/java/internal/ViewImpl.java b/sdk-java/src/main/java/ly/count/sdk/java/internal/ViewImpl.java
@@ -66,6 +66,11 @@ public void stop(boolean lastView) {
             return;
         }
 
+        if (start == null) {
+            L.e("stop: We are trying to end a view that has not been started.");
+            return;
+        }
+
         L.d("stop: lastView = " + lastView);
 
         if (ended) {