-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Java] Implement the new module for view tracking #182
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove "idv" and then add tests
feat: move convenient functions to utils
2701290
to
9120c8d
Compare
sdk-java/src/main/java/ly/count/sdk/java/internal/ModuleViews.java
Outdated
Show resolved
Hide resolved
sdk-java/src/main/java/ly/count/sdk/java/internal/ModuleViews.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
viewID and viewName to NonNull
Try to pull out whatever is possible to another PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add global segmentation.
introduce the view config object
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what can go wrong
sdk-java/src/main/java/ly/count/sdk/java/internal/ModuleEvents.java
Outdated
Show resolved
Hide resolved
sdk-java/src/main/java/ly/count/sdk/java/internal/ModuleEvents.java
Outdated
Show resolved
Hide resolved
sdk-java/src/main/java/ly/count/sdk/java/internal/ModuleViews.java
Outdated
Show resolved
Hide resolved
sdk-java/src/main/java/ly/count/sdk/java/internal/ModuleViews.java
Outdated
Show resolved
Hide resolved
sdk-java/src/main/java/ly/count/sdk/java/internal/ModuleViews.java
Outdated
Show resolved
Hide resolved
sdk-java/src/main/java/ly/count/sdk/java/internal/ModuleViews.java
Outdated
Show resolved
Hide resolved
sdk-java/src/main/java/ly/count/sdk/java/internal/ModuleViews.java
Outdated
Show resolved
Hide resolved
sdk-java/src/main/java/ly/count/sdk/java/internal/ModuleViews.java
Outdated
Show resolved
Hide resolved
sdk-java/src/main/java/ly/count/sdk/java/internal/ModuleViews.java
Outdated
Show resolved
Hide resolved
18035e9
to
171052f
Compare
* feat: view impl tests * feat: on session began callback * feat: add things to the stop * feat: all bad values and non existing ones * feat: scenario simple flow * fix: simple flow * fix: map usage * fix: rename * feat: segm testing1 * feat: mixed test flow 1 * feat: auto stopped ones * feat: validate segmentation 1 * feat: validate segmentation 2 * feat: validate internal keys * fix: int val check * fix: remove unused var * fix: delete unncessary things * chore: remove whitespcae * chore: whitespace * feat: module views test * feat: integrate views to flow * fix: undo * fix: add missing log * fix: regex pattern * fix: add changelog and deprecate * fix: remove unused import * fix: test thing * fix: device id tests * feat: test id generator * fix: view impl tests * fix: all view ids * feat: additional tests * fix: idx * feat: missing test logic * feat: new way of testing scneario * doc: update comment of scenario id * Update ScenarioManuelViewTests.java * feat: test prefixes * refactor: checkings * Update InternalConfig.java * Update InternalConfig.java * chore: naming sc * refactor: fix PR changes * feat: basic test about global segm * refactor: order * feat: view case proposal * feat: add missing test cases * feat: views module changes * fix: undo * fix: conflict * fix: conflict
No description provided.