Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java] Implement the new module for view tracking #182

Merged
merged 46 commits into from
Feb 1, 2024

Conversation

arifBurakDemiray
Copy link
Member

No description provided.

Copy link

github-actions bot commented Dec 7, 2023

Unit Test Results 🚀

0 tests   - 384   0 ✅  - 384   0s ⏱️ -22s
0 suites  -  31   0 💤 ±  0 
0 files    -  31   0 ❌ ±  0 

Results for commit 171052f. ± Comparison against base commit 1c119c0.

♻️ This comment has been updated with latest results.

Copy link
Member

@ArtursKadikis ArtursKadikis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove "idv" and then add tests

Copy link
Member

@ArtursKadikis ArtursKadikis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

viewID and viewName to NonNull
Try to pull out whatever is possible to another PR

CHANGELOG.md Show resolved Hide resolved
Copy link
Member

@ArtursKadikis ArtursKadikis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add global segmentation.
introduce the view config object

Copy link
Contributor

@turtledreams turtledreams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what can go wrong

* feat: view impl tests

* feat: on session began callback

* feat: add things to the stop

* feat: all bad values and non existing ones

* feat: scenario simple flow

* fix: simple flow

* fix: map usage

* fix: rename

* feat: segm testing1

* feat: mixed test flow 1

* feat: auto stopped ones

* feat: validate segmentation 1

* feat: validate segmentation 2

* feat: validate internal keys

* fix: int val check

* fix: remove unused var

* fix: delete unncessary things

* chore: remove whitespcae

* chore: whitespace

* feat: module views test

* feat: integrate views to flow

* fix: undo

* fix: add missing log

* fix: regex pattern

* fix: add changelog and deprecate

* fix: remove unused import

* fix: test thing

* fix: device id tests

* feat: test id generator

* fix: view impl tests

* fix: all view ids

* feat: additional tests

* fix: idx

* feat: missing test logic

* feat: new way of testing scneario

* doc: update comment of scenario id

* Update ScenarioManuelViewTests.java

* feat: test prefixes

* refactor: checkings

* Update InternalConfig.java

* Update InternalConfig.java

* chore: naming sc

* refactor: fix PR changes

* feat: basic test about global segm

* refactor: order

* feat: view case proposal

* feat: add missing test cases

* feat: views module changes

* fix: undo

* fix: conflict

* fix: conflict
@ArtursKadikis ArtursKadikis merged commit 26eaa06 into staging Feb 1, 2024
2 of 4 checks passed
@ArtursKadikis ArtursKadikis deleted the new_view_module branch February 1, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants