feat: set id #250
Merged
feat: set id #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit Test Results 🚀445 tests +5 444 ✅ +4 1m 18s ⏱️ +2s For more details on these failures, see this check. Results for commit 4f878b1. ± Comparison against base commit 04894bf. ♻️ This comment has been updated with latest results. |
ArtursKadikis
requested changes
Mar 22, 2024
sdk-java/src/main/java/ly/count/sdk/java/internal/ModuleDeviceIdCore.java
Outdated
Show resolved
Hide resolved
turtledreams
requested changes
Mar 25, 2024
sdk-java/src/test/java/ly/count/sdk/java/internal/ModuleDeviceIdTests.java
Show resolved
Hide resolved
sdk-java/src/test/java/ly/count/sdk/java/internal/ModuleDeviceIdTests.java
Show resolved
Hide resolved
sdk-java/src/test/java/ly/count/sdk/java/internal/ModuleDeviceIdTests.java
Outdated
Show resolved
Hide resolved
sdk-java/src/test/java/ly/count/sdk/java/internal/ModuleDeviceIdTests.java
Show resolved
Hide resolved
sdk-java/src/main/java/ly/count/sdk/java/internal/ModuleDeviceIdCore.java
Outdated
Show resolved
Hide resolved
turtledreams
requested changes
Mar 26, 2024
| validateDeviceIdWithMergeChange(oldDeviceId, 1, 2); | ||
| TestUtils.flushCurrentRQWithOldDeviceId(oldDeviceId); // clean current rq with old device id requests | ||
|
|
||
| deviceID.value += "1"; |
There was a problem hiding this comment.
well It is a little bit complicated validation. Because it is atomic it needed that way but I can set it more readeble
| Assert.assertEquals(0, TestUtils.getCurrentEQ().size()); // size should change because it is not a merge request | ||
|
|
||
| Assert.assertEquals(2, callCount.get()); | ||
| validateDeviceIdWithoutMergeChange(3, TestUtils.DEVICE_ID, false); // there should be 1 began, 1 events request |
There was a problem hiding this comment.
it is, did not it seem correct?
There was a problem hiding this comment.
yeap gives an error when I run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.