Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Java] rework event module #63

Merged
merged 95 commits into from
Sep 28, 2023
Merged

[Java] rework event module #63

merged 95 commits into from
Sep 28, 2023

Conversation

arifBurakDemiray
Copy link
Member

No description provided.

arifBurakDemiray and others added 25 commits September 18, 2023 11:28
@arifBurakDemiray
chore: ignore vscode path
3ffecf2
@arifBurakDemiray
feat: module events
4397867
@arifBurakDemiray
feat: new constructor for EventImpl
abd616c
@arifBurakDemiray
feat: new way of events module call
d42571c
@arifBurakDemiray
feat: module events
6e1b263
@arifBurakDemiray
fix: update version to 23.8.0
906d346
@arifBurakDemiray
Merge pull request #61 from Countly/staging
a867c1b 
Staging
@arifBurakDemiray
Merge pull request #62 from Countly/update_version
2b2ae27 
fix: update version to 23.8.0
@arifBurakDemiray
Merge branch 'remake_events_module' of https://github.com/Countly/cou…
44dabe0 
…ntly-sdk-java into remake_events_module
@arifBurakDemiray
feat: events module to sdk core
92c6041
@arifBurakDemiray
feat: end event deatiled
18782df
@arifBurakDemiray
feat: init check to events call
8bd5a24
@arifBurakDemiray
feat: event impl queue to store it in the future
a094d0b
@arifBurakDemiray
refactor: format and add java 8 way refactorings
70b2519
@arifBurakDemiray
refactor: deprecate session events and add new way of event addind
51255a3
@arifBurakDemiray
feat: add deprecated changelog
998e08b
@arifBurakDemiray
feat: add deprecated call for event
1046cbd
@arifBurakDemiray
feat: map in a beauty way,
5f85c58
@arifBurakDemiray
feat: info logs
661e8c5
@arifBurakDemiray
feat: timed events additionb
07b2551
@arifBurakDemiray
Merge pull request #64 from Countly/staging
cdf08d0 
fix: update version to 23.8.0 (#60)
@arifBurakDemiray
fix: remove unnecesaary check
ffb893c
@arifBurakDemiray
Merge branch 'remake_events_module' of https://github.com/Countly/cou…
aa16aea 
…ntly-sdk-java into remake_events_module
@arifBurakDemiray
feat: remove unnecessary check
5d94375
@arifBurakDemiray
fix: add correct param
10b113d
ArtursKadikis
ArtursKadikis requested changes Sep 19, 2023
View reviewed changes
Copy link
Member

@ArtursKadikis ArtursKadikis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move utility calls to a utility function.

Pull some additions out to a separate PR

Depracate "invalid" and the "event" call in usage" and the "event" interface

sdk-java/src/main/java/ly/count/sdk/java/internal/ModuleEvents.java Outdated Show resolved Hide resolved
ArtursKadikis
ArtursKadikis requested changes Sep 27, 2023
View reviewed changes
Copy link
Member

@ArtursKadikis ArtursKadikis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

finish refactoring tests

sdk-java/src/main/java/ly/count/sdk/java/internal/ModuleEvents.java Outdated Show resolved Hide resolved
sdk-java/src/main/java/ly/count/sdk/java/internal/EventImplQueue.java Outdated Show resolved Hide resolved
sdk-java/src/main/java/ly/count/sdk/java/internal/EventImplQueue.java Outdated Show resolved Hide resolved
ArtursKadikis
ArtursKadikis requested changes Sep 27, 2023
View reviewed changes
Copy link
Member

@ArtursKadikis ArtursKadikis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename "EventImplQueue" to "EventQueue"

ArtursKadikis
ArtursKadikis requested changes Sep 27, 2023
View reviewed changes
Copy link
Member

@ArtursKadikis ArtursKadikis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add tests for event queue

Add tests to validate the event threshold functionality

@arifBurakDemiray arifBurakDemiray changed the title Remake events module [Java] rework event module Sep 27, 2023
@ArtursKadikis ArtursKadikis merged commit 45224fc into staging Sep 28, 2023
2 checks passed
@ArtursKadikis ArtursKadikis deleted the remake_events_module branch September 28, 2023 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArtursKadikis ArtursKadikis ArtursKadikis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arifBurakDemiray @ArtursKadikis