Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java] Create a instant request maker #75

Merged
merged 21 commits into from
Sep 27, 2023
Merged

Conversation

arifBurakDemiray
Copy link
Member

No description provided.

@github-actions
Copy link

github-actions bot commented Sep 25, 2023

Unit Test Results 🚀

105 tests  +2   105 ✔️ +2   5s ⏱️ +5s
  14 suites +1       0 💤 ±0 
  14 files   +1       0 ±0 

Results for commit b23b11f. ± Comparison against base commit a09d737.

♻️ This comment has been updated with latest results.

Copy link
Member

@ArtursKadikis ArtursKadikis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's move things not related to the IRM to another PR.

Copy link
Member

@ArtursKadikis ArtursKadikis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's move things not related to the IRM to another PR.

Let's add a test that gives IRG override. And then verify that the callback returns the expected value.

Combine both "connection" calls

@ArtursKadikis ArtursKadikis merged commit f122322 into staging Sep 27, 2023
@ArtursKadikis ArtursKadikis deleted the instant_request branch September 27, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants