Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added CountlyConfig and initWithConfig #12

Merged
merged 11 commits into from
Apr 25, 2023
Merged

Conversation

peterBrxwn
Copy link
Contributor

No description provided.

Copy link
Member

@ArtursKadikis ArtursKadikis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is only 1 init. the approach that uses the config object.

@ArtursKadikis ArtursKadikis requested a review from ijunaid March 13, 2023 12:02

const successCodes = [100, 101, 200, 201, 202, 205, 300, 301, 303, 305];
const failureCodes = [400, 402, 405, 408, 500, 501, 502, 505];
const COUNTLY_APP_KEY = 'YOUR_APP_KEY';
const COUNTLY_SERVER_KEY = 'https://xxx.count.ly';
const COUNTLY_APP_KEY = '58594c9a3f461ebc000761a68c2146659ef75ea0';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's not have realy keys here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

@ArtursKadikis ArtursKadikis merged commit e7a77e6 into staging Apr 25, 2023
@ArtursKadikis ArtursKadikis deleted the init-config-object branch April 25, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants