Merge pull request #4655 from Countly/permission-fix

[SER-924] Add feature check in rights
Countly · Nov 1, 2023 · 0369b37 · 0369b37
2 parents 15ee93e + 1946bd3
commit 0369b37
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/api/utils/rights.js b/api/utils/rights.js
@@ -714,10 +714,12 @@ exports.validateRead = function(params, feature, callback, callbackParam) {
                         }
                         else {
                             isFeatureAllowedInReadPermissionObject = false;
-                            for (var i = 0; i < feature.length; i++) {
-                                if (isPermissionObjectExistForRead && (member.permission.r[params.qstring.app_id].all || (member.permission.r[params.qstring.app_id].allowed && member.permission.r[params.qstring.app_id].allowed[feature[i]]))) {
-                                    isFeatureAllowedInReadPermissionObject = true;
-                                    break;
+                            if (feature) {
+                                for (var i = 0; i < feature.length; i++) {
+                                    if (isPermissionObjectExistForRead && (member.permission.r[params.qstring.app_id].all || (member.permission.r[params.qstring.app_id].allowed && member.permission.r[params.qstring.app_id].allowed[feature[i]]))) {
+                                        isFeatureAllowedInReadPermissionObject = true;
+                                        break;
+                                    }
                                 }
                             }
                         }