Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new environments analysis, an experiment file, and a test #205

Open
wants to merge 61 commits into
base: master
Choose a base branch
from

Conversation

timzjing
Copy link
Contributor

@timzjing timzjing commented Jul 28, 2023

Also updated some tests for testing cell growth and division for the new metabolism process.

cyrus-bio and others added 30 commits June 12, 2023 11:31
@timzjing timzjing requested a review from cyrus-bio July 28, 2023 17:26
@cyrus-bio
Copy link
Contributor

Now that the ParCa has been integrated into the vivarium repo along with some new models from the wcEcoli repo, there's been a lot of changes to the repo since you started your summer project! Most of them will make our lives easier, but we'll probably have to do a slight restart of this PR. I didn't want you to clean up your PR twice, so I waited until I could make things work properly before dropping this comment, haha.

[Updating this comment with more info in the afternoon]

@cyrus-bio
Copy link
Contributor

What you'll want to do to merge with the new changes in the easiest way possible:

  • Pull the latest changes from the master branch into your current branch.
  • For running the model, what used to be MetabolismRedux is now MetabolismReduxClassic (I should come up with some better names, I know). MetabolismRedux uses growth rate control, which we're not going to introduce for now. So, for your experiment file, you'll want to use metabolism_redux_classic as your config instead (which uses metabolism_redux_classic.json in ecoli/composites/configs)
  • See if you can run the experiment file with that process instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants