Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch internal logic for handling prizes, or status of crates to be more event based. #785

Draft
wants to merge 20 commits into
base: main
Choose a base branch
from

Conversation

ryderbelserion
Copy link
Member

This is being done, as to make adding more crate types easier, as well as handling prizes becomes much easier. It condenses often duplicated chunks of code.

  • WonderCrate is broken, the way it handles giving prizes needs to be looked at it.
  • Add some form of skipping the animation to every crate, which could be done through simply shift clicking. Left shift-click opens the crate once with no animation, Right shift-click mass opens with no animations.
  • Migrate the rest of the crates to be event based.
  • Make proper use of the run() method, since the class inherits FoliaRunnable. we don't need to create an extra one. A few exceptions might be things like Cosmic Crate.

@ryderbelserion ryderbelserion added the status: in progress The pull request or feature in progress. label Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: in progress The pull request or feature in progress.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant