Merge pull request #18 from CrimsonChi/feat/watch

feat: Signal watch
CrimsonChi · Oct 13, 2024 · 5ff0f5c · 5ff0f5c
2 parents acaa414 + 6503a8a
commit 5ff0f5c
Show file tree

Hide file tree

Showing 5 changed files with 259 additions and 46 deletions.
diff --git a/packages/devtools-host/src/App.tsx b/packages/devtools-host/src/App.tsx
@@ -3,14 +3,7 @@ import { twMerge } from "tailwind-merge"
 import { Flame } from "./icon/Flame"
 import { useAnchorPos } from "./hooks/useAnchorPos"
 import { useEffectDeep, useSpring } from "@kaioken-core/hooks"
-import {
-  signal,
-  Transition,
-  useCallback,
-  useEffect,
-  useLayoutEffect,
-  useRef,
-} from "kaioken"
+import { signal, Transition, useEffect, useLayoutEffect, useRef } from "kaioken"
 import { useDevTools } from "./hooks/useDevtools"
 import { InspectComponent } from "./components/InspectComponent"
 import { PageInfo } from "./icon/PageInfo"

diff --git a/packages/lib/src/dom.ts b/packages/lib/src/dom.ts
@@ -182,10 +182,14 @@ function updateDom(vNode: VNode) {
           (vNode.cleanups[key](), delete vNode.cleanups[key])
       }
       if (Signal.isSignal(nextProps[key])) {
-        const unsub = nextProps[key].subscribe((v) => {
+        const cb: ((v: any) => void) & { vNodeFunc?: boolean } = (v: any) => {
           setProp(vNode, dom, key, v, unwrap(vNode.prev?.props[key]))
           emitGranularSignalChange(nextProps[key])
-        })
+        }
+        if (__DEV__) {
+          cb.vNodeFunc = true
+        }
+        const unsub = nextProps[key].subscribe(cb)
         ;(vNode.cleanups ??= {})[key] = unsub
         return setProp(
           vNode,
@@ -214,10 +218,14 @@ function emitGranularSignalChange(signal: Signal<any>) {
 }
 
 function subTextNode(vNode: VNode, textNode: Text, signal: Signal<string>) {
-  const unsub = signal.subscribe((v) => {
+  const cb: ((v: any) => void) & { vNodeFunc?: boolean } = (v) => {
     textNode.nodeValue = v
     emitGranularSignalChange(signal)
-  })
+  }
+  if (__DEV__) {
+    cb.vNodeFunc = true
+  }
+  const unsub = signal.subscribe(cb)
   ;(vNode.cleanups ??= {})["nodeValue"] = unsub
 }