Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor changes to space management #522

Open
wants to merge 5 commits into
base: prerelease
Choose a base branch
from

Conversation

MaadhyamRana
Copy link
Contributor

  • renamed '_frametimes' suffix to '_FT' in DeleteOldObservations
  • disabled quota management deletion by default

@dvida
Copy link
Contributor

dvida commented Feb 18, 2025

Thanks - it says in the comment that the quota managements has been disabled for testing purposes, is that still the case or we're no longer testing?

@MaadhyamRana
Copy link
Contributor Author

MaadhyamRana commented Feb 18, 2025

I only made the change to reflect what's present in the .config template, below is the section from the config. quota_management_disabled is 'true' by default:

; the next settings configure the archive management by space used on disk
; disabling quota management generates the reports, lists the files
; that would be deleted but prevents any action from being taken
; true = disabled, false = enabled
quota_management_disabled: true

@Cybis320
Copy link
Contributor

As a side note, the parameter is a bit unintuitive. To enable, set to false...

@g7gpr
Copy link
Contributor

g7gpr commented Feb 18, 2025

I'd prefer it to remain disabled by default; I'm testing it on several stations, including testing the interaction with the traditional quota management schemes. I'll report back when I'm satisfied that it does exactly what was intended.

@g7gpr
Copy link
Contributor

g7gpr commented Feb 19, 2025

However, @Cybis320 getting rid of the double negative, and using quota_management_enabled would be a good step to take.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants