Skip to content

Commit

Permalink
Merge pull request #175 from NullVoxPopuli/use-glint-1.0-and-make-gli…
Browse files Browse the repository at this point in the history
…nt-support-official

Upgrade Glint to post-1.0 and make Glint support official
  • Loading branch information
vitch authored May 16, 2023
2 parents 3f0f63c + 4681eca commit 9af6070
Show file tree
Hide file tree
Showing 7 changed files with 192 additions and 143 deletions.
5 changes: 5 additions & 0 deletions .changeset/warm-starfishes-behave.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'ember-headless-table': patch
---

Officially support Glint 1.0+
3 changes: 1 addition & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,7 @@ ember install ember-headless-table
* embroider safe + optimized
* typescript >= 4.8, [rolling window policy](https://www.semver-ts.org/#decouple-typescript-support-from-lts-cycles), range: TS@current-2 to TS@current (3 version window).
Note that types changes will be considered bugfixes until Glint support is added to ember-headless-table
* Glint -- not yet
All Glint changes will be considered bugfixes until Glint 1.0 is released.
* Glint -- 1.0+

### Usage

Expand Down
8 changes: 4 additions & 4 deletions docs-app/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,10 @@
"@embroider/webpack": "^2.0.2",
"@glimmer/component": "^1.1.2",
"@glimmer/tracking": "^1.1.2",
"@glint/core": "^0.9.7",
"@glint/environment-ember-loose": "^0.9.7",
"@glint/environment-ember-template-imports": "^0.9.7",
"@glint/template": "^0.9.7",
"@glint/core": "^1.0.2",
"@glint/environment-ember-loose": "^1.0.2",
"@glint/environment-ember-template-imports": "^1.0.2",
"@glint/template": "^1.0.2",
"@html-next/vertical-collection": "^4.0.2",
"@nullvoxpopuli/eslint-configs": "~2.2.59",
"@tailwindcss/typography": "^0.5.9",
Expand Down
5 changes: 2 additions & 3 deletions docs/typescript-and-glint.md
Original file line number Diff line number Diff line change
Expand Up @@ -72,9 +72,8 @@ class Demo {

## In Templates

[Glint][docs-glint] is still young, and pre-release, but it's proved it's worth -- and for new projects,
it can be a great choice to help ensure that your code is as bug-free as possible.
Glint was the missing for TypeScript to truely shine in Ember, and this library strives to make sure that
[Glint][docs-glint] can be a great choice to help ensure that your code is as bug-free as possible.
Glint was the missing piece for TypeScript to truly shine in Ember, and this library strives to make sure that
inference of all public APIs (properties, plugin-configs, etc) _works by default_.

Here are a couple screenshots from our own tests showing that Glint provides intellisense and JSDoc documentation in VSCode:
Expand Down
2 changes: 1 addition & 1 deletion ember-headless-table/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@
"@embroider/addon-dev": "^3.0.0",
"@glimmer/component": "^1.1.2",
"@glimmer/tracking": "^1.1.2",
"@glint/template": "^0.9.4",
"@glint/template": "^1.0.2",
"@nullvoxpopuli/eslint-configs": "~2.2.57",
"@rollup/plugin-babel": "^6.0.0",
"@tsconfig/ember": "^2.0.0",
Expand Down
304 changes: 175 additions & 129 deletions pnpm-lock.yaml

Large diffs are not rendered by default.

8 changes: 4 additions & 4 deletions test-app/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -44,10 +44,10 @@
"@embroider/test-setup": "^2.0.2",
"@glimmer/component": "^1.1.2",
"@glimmer/tracking": "^1.1.2",
"@glint/core": "^0.9.7",
"@glint/environment-ember-loose": "^0.9.7",
"@glint/environment-ember-template-imports": "^0.9.7",
"@glint/template": "^0.9.7",
"@glint/core": "^1.0.2",
"@glint/environment-ember-loose": "^1.0.2",
"@glint/environment-ember-template-imports": "^1.0.2",
"@glint/template": "^1.0.2",
"@nullvoxpopuli/eslint-configs": "~2.2.57",
"@tsconfig/ember": "^1.0.1",
"@types/babel__traverse": "^7.18.2",
Expand Down

0 comments on commit 9af6070

Please sign in to comment.